From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbcFGO2m (ORCPT ); Tue, 7 Jun 2016 10:28:42 -0400 Received: from down.free-electrons.com ([37.187.137.238]:39208 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752889AbcFGO2l (ORCPT ); Tue, 7 Jun 2016 10:28:41 -0400 From: Gregory CLEMENT To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Daniel Lezcano , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static References: <1465309073-20584-1-git-send-email-ben.dooks@codethink.co.uk> Date: Tue, 07 Jun 2016 16:28:39 +0200 In-Reply-To: <1465309073-20584-1-git-send-email-ben.dooks@codethink.co.uk> (Ben Dooks's message of "Tue, 7 Jun 2016 15:17:53 +0100") Message-ID: <87k2i1oyy0.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ben, On mar., juin 07 2016, Ben Dooks wrote: > The driver does not export armada_370_xp_timer_syscore_ops so > make it static to fix the following warning: > > drivers/clocksource/time-armada-370-xp.c:249:20: warning: symbol 'armada_370_xp_timer_syscore_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Acked-by: Gregory CLEMENT Thanks, Gregory > --- > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Gregory CLEMENT > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/clocksource/time-armada-370-xp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c > index d93ec3c..601dbf74 100644 > --- a/drivers/clocksource/time-armada-370-xp.c > +++ b/drivers/clocksource/time-armada-370-xp.c > @@ -246,7 +246,7 @@ static void armada_370_xp_timer_resume(void) > writel(timer0_local_ctrl_reg, local_base + TIMER_CTRL_OFF); > } > > -struct syscore_ops armada_370_xp_timer_syscore_ops = { > +static struct syscore_ops armada_370_xp_timer_syscore_ops = { > .suspend = armada_370_xp_timer_suspend, > .resume = armada_370_xp_timer_resume, > }; > -- > 2.8.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com