linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Chunyan Zhang <zhang.chunyan@linaro.org>, mathieu.poirier@linaro.org
Cc: robh@kernel.org, broonie@kernel.org, pratikp@codeaurora.org,
	nicolas.guion@st.com, corbet@lwn.net, mark.rutland@arm.com,
	mike.leach@arm.com, tor@ti.com, al.grant@arm.com,
	zhang.lyra@gmail.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH V2 1/6] stm class: Add ioctl get_options interface
Date: Fri, 05 Feb 2016 14:55:31 +0200	[thread overview]
Message-ID: <87k2mj5nb0.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <1454487337-30184-2-git-send-email-zhang.chunyan@linaro.org>

Chunyan Zhang <zhang.chunyan@linaro.org> writes:

> There is already an interface of set_options, but no get_options yet.
> Before setting any options, one would may want to see the current
> status of that option by means of get_options interface. This
> interface has been used in CoreSight STM driver.
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> ---
>  drivers/hwtracing/stm/core.c | 11 +++++++++++
>  include/linux/stm.h          |  3 +++
>  include/uapi/linux/stm.h     |  1 +
>  3 files changed, 15 insertions(+)
>
> diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
> index b6445d9..86bb4e3 100644
> --- a/drivers/hwtracing/stm/core.c
> +++ b/drivers/hwtracing/stm/core.c
> @@ -571,6 +571,17 @@ stm_char_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  						    options);
>  
>  		break;
> +
> +	case STP_GET_OPTIONS:
> +		if (stm_data->get_options)
> +			err = stm_data->get_options(stm_data,
> +						    stmf->output.master,
> +						    stmf->output.channel,
> +						    stmf->output.nr_chans,
> +						    &options);
> +
> +		return copy_to_user((void __user *)arg, &options, sizeof(u64));

The return value of copy_to_user() is not what you assume it is.

Regards,
--
Alex

  reply	other threads:[~2016-02-05 12:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03  8:15 [PATCH V2 0/6] Introduce CoreSight STM support Chunyan Zhang
2016-02-03  8:15 ` [PATCH V2 1/6] stm class: Add ioctl get_options interface Chunyan Zhang
2016-02-05 12:55   ` Alexander Shishkin [this message]
2016-02-03  8:15 ` [PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name Chunyan Zhang
2016-02-03 10:05   ` [PATCH] stm class: fix semicolon.cocci warnings kbuild test robot
2016-02-03 10:05   ` [PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name kbuild test robot
2016-02-04  8:56   ` Chunyan Zhang
2016-02-04 17:30     ` Alexander Shishkin
2016-02-05  3:18       ` Chunyan Zhang
2016-02-03  8:15 ` [PATCH V2 3/6] stm class: provision for statically assigned masterIDs Chunyan Zhang
2016-02-05 12:52   ` Alexander Shishkin
2016-02-05 16:31     ` Mike Leach
2016-02-08 10:52       ` Alexander Shishkin
2016-02-05 18:08     ` Mathieu Poirier
2016-02-08 13:26       ` Alexander Shishkin
2016-02-08 17:05         ` Mathieu Poirier
2016-02-08 17:44           ` Al Grant
2016-02-09 17:06             ` Mathieu Poirier
2016-02-12 15:54             ` Alexander Shishkin
2016-02-12 16:27           ` Alexander Shishkin
2016-02-12 20:33             ` Mathieu Poirier
2016-02-22 18:01               ` Mathieu Poirier
2016-02-03  8:15 ` [PATCH V2 4/6] Documentations: Add explanations of the case for non-configurable masters Chunyan Zhang
2016-02-03  8:15 ` [PATCH V2 5/6] coresight-stm: Bindings for System Trace Macrocell Chunyan Zhang
2016-02-03  8:15 ` [PATCH V2 6/6] coresight-stm: adding driver for CoreSight STM component Chunyan Zhang
2016-02-05 13:06   ` Alexander Shishkin
2016-02-05 14:30     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2mj5nb0.fsf@ashishki-desk.ger.corp.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=al.grant@arm.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@arm.com \
    --cc=nicolas.guion@st.com \
    --cc=pratikp@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=tor@ti.com \
    --cc=zhang.chunyan@linaro.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).