From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Lewis Robbins <lewis.robbins2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw88: reduce failed to flush queue severity
Date: Mon, 15 Apr 2024 19:16:25 +0300 [thread overview]
Message-ID: <87le5ey52e.fsf@kernel.org> (raw)
In-Reply-To: <694ac10692114ed8838909df5010687a@realtek.com> (Ping-Ke Shih's message of "Mon, 15 Apr 2024 01:40:36 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
> Lewis Robbins <lewis.robbins2@gmail.com> wrote:
>>
>> Reduce the log message severity when we fail to flush device priority
>> queue. If a system has a lot of traffic, we may fail to flush the queue
>> in time. This generates a lot of messages in the kernel ring buffer. As
>> this is a common occurrence, we should use dev_info instead of dev_warn.
>>
>> Signed-off-by: Lewis Robbins <lewis.robbins2@gmail.com>
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> I'd like to know situations of " If a system has a lot of traffic...".
> Did you scan or do something during traffic?
The driver shouldn't print any warnings in normal usage, even using info
level. If this is expected scenario then maybe change it to debug print?
Or if is this an actual bug then it's better try to investigate and fix
it.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-15 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 22:59 [PATCH] wifi: rtw88: reduce failed to flush queue severity Lewis Robbins
2024-04-15 1:40 ` Ping-Ke Shih
2024-04-15 16:16 ` Kalle Valo [this message]
2024-04-15 23:28 ` Lewis Robbins
2024-04-16 2:57 ` Ping-Ke Shih
2024-04-17 1:42 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le5ey52e.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=lewis.robbins2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).