From: Thomas Gleixner <tglx@linutronix.de>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-mips@vger.kernel.org, lvjianmin@loongson.cn,
WANG Xuerui <git@xen0n.name>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Binbin Zhou <zhoubinbin@loongson.cn>
Subject: Re: [PATCH v5 4/5] irqchip/loongson-liointc: Fix 'loongson,parent_int_map' parse
Date: Fri, 08 Dec 2023 15:20:06 +0100 [thread overview]
Message-ID: <87lea4srmx.ffs@tglx> (raw)
In-Reply-To: <fc9b3afaf8826fd437ba91397eb7fa231db2c05c.1700449792.git.zhoubinbin@loongson.cn>
On Mon, Nov 20 2023 at 17:06, Binbin Zhou wrote:
$Subject: s/parse/parsing/
> In keeping with naming standards, 'loongson,parent_int_map' is renamed
> to 'loongson,parent-int-map'. But for the driver, we need to make sure
> that both forms can be parsed.
Please keep changelogs in neutral or imperative tone:
For backwards compatibility it is required to parse the original
string too.
Makes it entirely clear what this is about without 'we'. See also:
https://www.kernel.org/doc/html/latest/process/submitting-patches.rst
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> drivers/irqchip/irq-loongson-liointc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
> index e4b33aed1c97..add2e0a955b8 100644
> --- a/drivers/irqchip/irq-loongson-liointc.c
> +++ b/drivers/irqchip/irq-loongson-liointc.c
> @@ -330,6 +330,7 @@ static int __init liointc_of_init(struct device_node *node,
> bool have_parent = FALSE;
> int sz, i, index, revision, err = 0;
> struct resource res;
> + const char *prop_name = "loongson,parent-int-map";
Please don't glue variables randomly into the declaration section:
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations
> if (!of_device_is_compatible(node, "loongson,liointc-2.0")) {
> index = 0;
> @@ -350,8 +351,12 @@ static int __init liointc_of_init(struct device_node *node,
> if (!have_parent)
> return -ENODEV;
>
> + if (!of_find_property(node, prop_name, &i))
> + /* Fallback to 'loongson,parent_int_map'. */
> + prop_name = "loongson,parent_int_map";
This lacks curly brackets:
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
> sz = of_property_read_variable_u32_array(node,
> - "loongson,parent_int_map",
> + prop_name,
> &parent_int_map[0],
> LIOINTC_NUM_PARENT,
> LIOINTC_NUM_PARENT);
Thanks,
tglx
next prev parent reply other threads:[~2023-12-08 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 9:06 [PATCH v5 0/5] dt-bindings: interrupt-controller: Fix some loongson,liointc warnings Binbin Zhou
2023-11-20 9:06 ` [PATCH v5 1/5] dt-bindings: interrupt-controller: loongson,liointc: Standardize the naming of 'loongson,parent-int-map' Binbin Zhou
2023-11-27 18:28 ` Rob Herring
2023-11-30 13:02 ` Binbin Zhou
2023-11-20 9:06 ` [PATCH v5 2/5] dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check warning for reg-names Binbin Zhou
2023-11-20 9:06 ` [PATCH v5 3/5] dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check warning for interrupt-names Binbin Zhou
2023-11-20 9:06 ` [PATCH v5 4/5] irqchip/loongson-liointc: Fix 'loongson,parent_int_map' parse Binbin Zhou
2023-12-08 14:20 ` Thomas Gleixner [this message]
2023-12-11 2:37 ` Binbin Zhou
2023-11-20 9:06 ` [PATCH v5 5/5] MIPS: Loongson64: DTS: Fix 'loongson,parent_int_map' references Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lea4srmx.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xen0n.name \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).