Re: [PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()

From: "Huang, Ying" <ying.huang@intel.com>
To: Longlong Xia <xialonglong1@huawei.com>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, <chenwandun@huawei.com>,
	<wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>
Subject: Re: [PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()
Date: Tue, 31 Jan 2023 15:27:44 +0800	[thread overview]
Message-ID: <87leljrwnj.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20230131071035.1085968-1-xialonglong1@huawei.com> (Longlong Xia's message of "Tue, 31 Jan 2023 07:10:35 +0000")

Longlong Xia <xialonglong1@huawei.com> writes:

> It's known that get_swap_pages() may fail to find available space
> under some extreme case, but pr_debug() provides useless information.
> Let's remove it.
>
> Signed-off-by: Longlong Xia <xialonglong1@huawei.com>

Thanks!

Reviewed-by: "Huang, Ying" <ying.huang@intel.com>

> ---
>  mm/swapfile.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 6202a6668a63..99143875d6f0 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -1098,8 +1098,6 @@ int get_swap_pages(int n_goal, swp_entry_t swp_entries[], int entry_size)
>  		spin_unlock(&si->lock);
>  		if (n_ret || size == SWAPFILE_CLUSTER)
>  			goto check_out;
> -		pr_debug("scan_swap_map of si %d failed to find offset\n",
> -			si->type);
>  		cond_resched();
>  
>  		spin_lock(&swap_avail_lock);