From: Marc Zyngier <maz@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] platform: finally disallow IRQ0 in platform_get_irq() and its ilk
Date: Tue, 04 Jan 2022 11:13:43 +0000 [thread overview]
Message-ID: <87lezvvjmg.wl-maz@kernel.org> (raw)
In-Reply-To: <YdQnLuQseVhq40yd@kroah.com>
On Tue, 04 Jan 2022 10:53:34 +0000,
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jan 04, 2022 at 10:48:00AM +0000, Marc Zyngier wrote:
> > On Tue, 04 Jan 2022 09:47:21 +0000,
> > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > >
> > > On Tue, Jan 4, 2022 at 10:26 AM Marc Zyngier <maz@kernel.org> wrote:
> > > > Geert recently mentioned that a few architectures (such as sh?) still
> > > > use IRQ0 as something valid in limited cases.
> > >
> > > https://lore.kernel.org/all/CAMuHMdUg3=q7gyaVHP0XcYUOo3PQUUv8Hc8wp5faVQ+bTBpg4A@mail.gmail.com
> > >
> > > TL;DR: Probably only smsc911x Ethernet on the AP-SH4A-3A and
> > > AP-SH4AD-0A boards, which should trigger the warning since v5.8.
> > >
> > > > From my PoV, this patch is fine, but please be prepared to fix things
> > > > in a couple of years when someone decides to boot a recent kernel on
> > > > their pet dinosaur. With that in mind:
> > > >
> > > > Acked-by: Marc Zyngier <maz@kernel.org>
> > >
> > > TBH, I don't see much point in this patch, as the WARN() has been
> > > there since a while, and the end goal is to return zero instead of
> > > -ENXIO for no interrupt, right?
> >
> > I think the end-goal is to never return 0. Either we return a valid
> > interrupt number, or we return an error. It should be the
> > responsibility of the caller to decide what they want to do in the
> > error case.
>
> As 0 still is a valid irq for some platforms (as mentioned above), then
> how is this ever going to be possible?
Fixing the offending platforms should be a pre-requisite. At least the
ones we know about.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-01-04 11:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 20:26 [PATCH] platform: finally disallow IRQ0 in platform_get_irq() and its ilk Sergey Shtylyov
2021-11-26 16:20 ` Greg Kroah-Hartman
2021-12-02 21:11 ` Sergey Shtylyov
2021-12-09 20:06 ` Andy Shevchenko
2021-12-09 20:21 ` Sergey Shtylyov
2021-12-10 11:17 ` Andy Shevchenko
2022-01-04 19:27 ` Sergey Shtylyov
2022-01-05 10:09 ` Andy Shevchenko
2022-01-09 11:31 ` Sergey Shtylyov
2022-01-04 9:26 ` Marc Zyngier
2022-01-04 9:47 ` Geert Uytterhoeven
2022-01-04 10:48 ` Marc Zyngier
2022-01-04 10:53 ` Greg Kroah-Hartman
2022-01-04 11:13 ` Marc Zyngier [this message]
2022-01-05 10:02 ` Andy Shevchenko
2022-01-04 11:24 ` Geert Uytterhoeven
2022-01-05 9:59 ` Andy Shevchenko
2022-01-04 12:23 ` Sergey Shtylyov
2022-01-04 20:30 ` Sergey Shtylyov
2022-01-12 17:53 ` Sergey Shtylyov
2022-01-12 18:08 ` Marc Zyngier
2022-01-12 20:08 ` Sergey Shtylyov
2022-02-11 20:20 ` Sergey Shtylyov
2022-01-12 18:19 ` Greg Kroah-Hartman
2022-01-12 20:20 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lezvvjmg.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).