From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC4EC4338F for ; Mon, 9 Aug 2021 08:18:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 109486113C for ; Mon, 9 Aug 2021 08:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233897AbhHIITB (ORCPT ); Mon, 9 Aug 2021 04:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233888AbhHIITA (ORCPT ); Mon, 9 Aug 2021 04:19:00 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DD40C0613CF for ; Mon, 9 Aug 2021 01:18:40 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628497119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dHiapdGIx1XQgnVPzSifyQPqZ+8Im0TDS7MbfUXmGCM=; b=yZJSvqh70cSboFE0f6UZr4jR/TnbU8oYU/nk/xdkJIMoLVkMqJIewBo4SviYke8pq4zUZb zffFwwUlddwqPdtT2/K5anVRS4CkZbShNpJHThaXaY5qBaGUbQgXOz8hpFhfNb4ERjKlPJ QUzntcJokNno/3xfl6m+DQV6GsqTui0/uSEwDlbsY7atem6NIWYpz8IyRtq7pd01Mm0MI7 Kpts2r6ujBBsI4djN384uWY3rjKAl3lww//7+ZnSaCCX+lbsvTrn+O6lKQv/VhCP/X0H0b PUzI26YQ91J1QEVXmNCTmarV0lgJZmZzwGrb8JR7295iTezqvJHjh5vEFxIyYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628497119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dHiapdGIx1XQgnVPzSifyQPqZ+8Im0TDS7MbfUXmGCM=; b=TFhMEtLd4fyM8vz5Xdoq0qTqxAtGpIJjTR9ggBgri2PG45iGu0413r9UrDqeLPevammrEI J+1wdZR1O9wh8HAg== To: Davidlohr Bueso Cc: LKML , Peter Zijlstra , Ingo Molnar , Juri Lelli , Steven Rostedt , Daniel Bristot de Oliveira , Will Deacon , Waiman Long , Boqun Feng , Sebastian Andrzej Siewior , Mike Galbraith Subject: Re: [patch V3 58/64] futex: Clarify comment in futex_requeue() In-Reply-To: <20210808184320.zytackz5nf37brqu@offworld> References: <20210805151300.330412127@linutronix.de> <20210805153956.161214930@linutronix.de> <20210808184320.zytackz5nf37brqu@offworld> Date: Mon, 09 Aug 2021 10:18:38 +0200 Message-ID: <87lf5bt4ip.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 08 2021 at 11:43, Davidlohr Bueso wrote: > On Thu, 05 Aug 2021, Thomas Gleixner wrote: > >>From: Thomas Gleixner >> >>The comment about the restriction of the number of waiters to wake for the >>REQUEUE_PI case is confusing at best. Rewrite it. > > This certainly reads better. > >> >>Signed-off-by: Thomas Gleixner >>--- >> kernel/futex.c | 28 ++++++++++++++++++++-------- >> 1 file changed, 20 insertions(+), 8 deletions(-) >>--- >>--- a/kernel/futex.c >>+++ b/kernel/futex.c >>@@ -1960,15 +1960,27 @@ static int futex_requeue(u32 __user *uad >> */ >> if (refill_pi_state_cache()) >> return -ENOMEM; > > Perhaps this can be moved after the nr_wake check below? No sense > in calling refill_pi_state_cache() if the user is passing bogus > parameters. Yes.