From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76872C4338F for ; Mon, 26 Jul 2021 13:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AC3E60F42 for ; Mon, 26 Jul 2021 13:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234273AbhGZNEd (ORCPT ); Mon, 26 Jul 2021 09:04:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:32986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233993AbhGZNEa (ORCPT ); Mon, 26 Jul 2021 09:04:30 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B59560F42; Mon, 26 Jul 2021 13:44:59 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m80uf-0013G7-7A; Mon, 26 Jul 2021 14:44:57 +0100 Date: Mon, 26 Jul 2021 14:44:56 +0100 Message-ID: <87lf5tdw9z.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Daniel Lezcano , Rob Herring , Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bin Meng Subject: Re: [RFC PATCH v2 02/11] RISC-V: Use common print prefix in smp.c In-Reply-To: <20210618123851.1344518-3-anup.patel@wdc.com> References: <20210618123851.1344518-1-anup.patel@wdc.com> <20210618123851.1344518-3-anup.patel@wdc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anup.patel@wdc.com, palmer@dabbelt.com, palmerdabbelt@google.com, paul.walmsley@sifive.com, tglx@linutronix.de, daniel.lezcano@linaro.org, robh+dt@kernel.org, atish.patra@wdc.com, Alistair.Francis@wdc.com, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, bmeng.cn@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Jun 2021 13:38:42 +0100, Anup Patel wrote: > > We add "#define pr_fmt()" in smp.c to use "riscv:" as common > print prefix for all pr_xyz() statements in this file. > > Signed-off-by: Anup Patel > Reviewed-by: Bin Meng > --- > arch/riscv/kernel/smp.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c > index 547dc508f7d1..eea0c9d11d9f 100644 > --- a/arch/riscv/kernel/smp.c > +++ b/arch/riscv/kernel/smp.c > @@ -8,6 +8,7 @@ > * Copyright (C) 2017 SiFive > */ > > +#define pr_fmt(fmt) "riscv: " fmt > #include > #include > #include > @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) > if (ipi_ops && ipi_ops->ipi_inject) > ipi_ops->ipi_inject(mask); > else > - pr_warn("SMP: IPI inject method not available\n"); > + pr_warn("IPI inject method not available\n"); > } > > static void send_ipi_single(int cpu, enum ipi_message_type op) > @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op) > if (ipi_ops && ipi_ops->ipi_inject) > ipi_ops->ipi_inject(cpumask_of(cpu)); > else > - pr_warn("SMP: IPI inject method not available\n"); > + pr_warn("IPI inject method not available\n"); "SMP:" made a lot more sense. I assume that the user knows that they are using a RISC-V machine. On the other hand, seeing a "SMP:" prefix for a message indicates the provenance of the message. I honestly don't see the point in this change. M. -- Without deviation from the norm, progress is not possible.