From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F355C4338F for ; Fri, 23 Jul 2021 12:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7D4A60F12 for ; Fri, 23 Jul 2021 12:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235143AbhGWMQX convert rfc822-to-8bit (ORCPT ); Fri, 23 Jul 2021 08:16:23 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44479 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235336AbhGWMQT (ORCPT ); Fri, 23 Jul 2021 08:16:19 -0400 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 786BDC000C; Fri, 23 Jul 2021 12:56:50 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Marek =?utf-8?Q?Beh=C3=BAn?= , Russell King Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode In-Reply-To: <20210628151229.25214-1-pali@kernel.org> References: <20210628121015.22660-1-pali@kernel.org> <20210628151229.25214-1-pali@kernel.org> Date: Fri, 23 Jul 2021 14:56:50 +0200 Message-ID: <87lf5x194d.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pali, > Some SFP modules are not detected when i2c-fast-mode is enabled even when > clock-frequency is already set to 100000. The I2C bus violates the timing > specifications when run in fast mode. So disable fast mode on Turris Mox. > > Same change was already applied for uDPU (also Armada 3720 board with SFP) > in commit fe3ec631a77d ("arm64: dts: uDPU: remove i2c-fast-mode"). > > Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox") > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Applied on mvebu/fixes Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 6bcc319a0161..85f15f2a4740 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -119,6 +119,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&i2c1_pins>; > clock-frequency = <100000>; > + /delete-property/ mrvl,i2c-fast-mode; > status = "okay"; > > rtc@6f { > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com