From: Michael Ellerman <mpe@ellerman.id.au>
To: Nick Desaulniers <ndesaulniers@google.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
clang-built-linux@googlegroups.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough
Date: Wed, 18 Nov 2020 10:46:32 +1100 [thread overview]
Message-ID: <87lfez35t3.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20201116043532.4032932-4-ndesaulniers@google.com>
Nick Desaulniers <ndesaulniers@google.com> writes:
> The "fallthrough" pseudo-keyword was added as a portable way to denote
> intentional fallthrough. Clang will still warn on cases where there is a
> fallthrough to an immediate break. Add explicit breaks for those cases.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/236
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/powerpc/kernel/prom_init.c | 1 +
> arch/powerpc/kernel/uprobes.c | 1 +
> arch/powerpc/perf/imc-pmu.c | 1 +
> 3 files changed, 3 insertions(+)
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
prev parent reply other threads:[~2020-11-17 23:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 4:35 [PATCH 0/3] PPC: Fix -Wimplicit-fallthrough for clang Nick Desaulniers
2020-11-16 4:35 ` [PATCH 1/3] powerpc: boot: include compiler_attributes.h Nick Desaulniers
2020-11-16 6:25 ` Gustavo A. R. Silva
2020-11-16 11:24 ` Miguel Ojeda
2020-11-17 3:01 ` Nathan Chancellor
2020-11-17 22:30 ` Arvind Sankar
2020-11-17 23:46 ` Michael Ellerman
2020-11-16 4:35 ` [PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/" Nick Desaulniers
2020-11-16 6:26 ` Gustavo A. R. Silva
2020-11-16 11:18 ` Miguel Ojeda
2020-11-16 11:26 ` Miguel Ojeda
2020-11-16 11:49 ` kernel test robot
2020-11-17 3:02 ` Nathan Chancellor
2020-11-17 19:10 ` Nick Desaulniers
2020-11-17 22:16 ` Gustavo A. R. Silva
2020-11-17 22:28 ` Nick Desaulniers
2020-11-17 23:45 ` Gustavo A. R. Silva
2020-11-17 23:48 ` Michael Ellerman
2020-11-16 4:35 ` [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough Nick Desaulniers
2020-11-16 6:28 ` Gustavo A. R. Silva
2020-11-16 11:33 ` Miguel Ojeda
2020-11-17 3:02 ` Nathan Chancellor
2020-11-17 23:46 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfez35t3.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).