From: Baruch Siach <baruch@tkos.co.il>
To: linux-arm-kernel@lists.infradead.org
Cc: "robh+dt\@kernel.org" <robh+dt@kernel.org>,
"mark.rutland\@arm.com" <mark.rutland@arm.com>,
"shawnguo\@kernel.org" <shawnguo@kernel.org>,
"kernel\@pengutronix.de" <kernel@pengutronix.de>,
"festevam\@gmail.com" <festevam@gmail.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
Peng Fan <peng.fan@nxp.com>, Alice Guo <alice.guo@nxp.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] arm: dts: imx7ulp: fix reg of cpu node
Date: Wed, 18 Dec 2019 14:07:57 +0200 [thread overview]
Message-ID: <87lfr9suoy.fsf@tarshish> (raw)
In-Reply-To: <1576670430-14226-1-git-send-email-peng.fan@nxp.com>
Hi Peng,
On Wed, Dec 18 2019, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> According to arm cpus binding doc,
> "
> On 32-bit ARM v7 or later systems this property is
> required and matches the CPU MPIDR[23:0] register
> bits.
>
> Bits [23:0] in the reg cell must be set to
> bits [23:0] in MPIDR.
>
> All other bits in the reg cell must be set to 0.
> "
>
> In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
> Otherwise there will be warning:
> "DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
>
> Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm/boot/dts/imx7ulp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index d37a1927c88e..aa9e50178d6b 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -40,7 +40,7 @@
> cpu0: cpu@0 {
The address suffix in the node name should update to match 'reg'.
> compatible = "arm,cortex-a7";
> device_type = "cpu";
> - reg = <0>;
> + reg = <0xf00>;
> };
> };
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-12-18 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 12:03 [PATCH] arm: dts: imx7ulp: fix reg of cpu node Peng Fan
2019-12-18 12:07 ` Baruch Siach [this message]
2019-12-18 12:10 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfr9suoy.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=aisheng.dong@nxp.com \
--cc=alice.guo@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).