From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jonathan Corbet <corbet@lwn.net>,
Christoph Niedermaier <cniedermaier@dh-electronics.de>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, C.Emde@osadl.org
Subject: Re: [PATCH 0/2] Docs/EDID: Fixed and improved EDID documentation
Date: Tue, 13 Nov 2018 21:45:29 +0200 [thread overview]
Message-ID: <87lg5wg3s6.fsf@intel.com> (raw)
In-Reply-To: <20181106073536.58b14759@lwn.net>
On Tue, 06 Nov 2018, Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 5 Nov 2018 09:48:33 +0100
> Christoph Niedermaier <cniedermaier@dh-electronics.de> wrote:
>
>> A problem was found when EDID data sets for displays other
>> than the provided samples were generated. The patch series has
>> no effect on the provided samples that still match the data
>> used in drivers/gpu/drm/drm_edid_load.c.
>> The provided samples use small values for XOFFSET, XPULSE,
>> YOFFSET and YPULSE, where the error doesn't occur. This fix
>> corrects the use of that values in case of high values, because
>> the most significant bits were treated incorrectly.
>>
>> The previous version made it necessary to first generate an
>> EDID data set without correct CRC and then to fix the CRC in
>> a second step. This patch series adds the CRC calculation to the
>> makefile in such a way that a correct EDID data set is generated
>> in a single build step.
>
> This seems reasonable, I guess; I've applied both. It seems to me, though,
> that this stuff is in the wrong place. Perhaps we should go one step
> further and move it to tools/ ?
And then the next step further would be to write a tool in a high level
language to generate the data rather than assemble the binary. Such a
tool would, of course, catch errors like the ones fixed by this patch.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2018-11-13 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 8:48 [PATCH 0/2] Docs/EDID: Fixed and improved EDID documentation Christoph Niedermaier
2018-11-05 8:48 ` [PATCH 1/2] Docs/EDID: Fixed erroneous bits of XOFFSET, XPULSE, YOFFSET and YPULSE Christoph Niedermaier
2018-11-05 8:48 ` [PATCH 2/2] Docs/EDID: Calculate CRC while building the code Christoph Niedermaier
2018-11-06 14:35 ` [PATCH 0/2] Docs/EDID: Fixed and improved EDID documentation Jonathan Corbet
2018-11-13 19:45 ` Jani Nikula [this message]
2018-11-15 9:02 ` Christoph Niedermaier
2018-11-15 8:37 ` Christoph Niedermaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg5wg3s6.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=C.Emde@osadl.org \
--cc=cniedermaier@dh-electronics.de \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).