From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3932033-1516368210-2-17640158968445506600 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: from='utf-8', plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516368209; b=Ba7x4tzOYEB7siPUj5XErqFy4xTmnsb7nWmQVRiTD+pB7gW 2BNESu1QQpjC07IAHKE1MNoQF4m/hoCHT170NWqbw8RS6CROqaJXwo4x1vNzqqWH 6lIGTfdsiU1uQ8Hi/4KkncKZ7OBjmuWb3UTSDC+6VGIGXlvGuc4qDVSYsIkZBzLW 0DLBlgoang5BbjU1bYtRqgTByzzrK+sVYl4P47L7Ps7V0/dLVBPe4KvIHZIiCKIE ESsS5KKwQ7p6iBOisrcKYDN1Q+Y8BWj/oCIevBOnXNQS6r/BXb088XSxgwaPMOaC 0Me8Ip8AMS4VztdXA4+5RuDREY/4+mAsoXv6Jsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516368209; bh=wgApehceE4g80BPQBpf87JC14e6PS5sz6BmVhO/TttU=; b=P WDRH/Kx18W6jN8ShQcwGoZkDIfQMzy9HRDHBfy3xglzGe5Yr9MsfjoG9KeoiSUQi Awx17dhftgYw++Zcc1pkrZxjJeUcmjqN/9a52URr3NG8J+J0JI5JfuxhKkFKHHZK NRjbeEWESoV9xB08z/grY809sk/+mLUXvgMDAwSFfxQ6APrtrbxn8d8OyIGa6/as pyZxMx/id1j2Dr+mDt7AW1q28xhNDaQ2A9E1cltL1ND77u2duENHiLhiG/gLqg/8 ULOuqo9oWmaI2faMUoyb+38sGagQrHnM+n4NTW6vV53GzolkqGaBrUfi1kAfQEC+ N31HY5UNrR9wK/2v2fKfg== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=suse.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=suse.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=suse.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=suse.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbeASNX1 convert rfc822-to-8bit (ORCPT ); Fri, 19 Jan 2018 08:23:27 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:44437 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754440AbeASNX0 (ORCPT ); Fri, 19 Jan 2018 08:23:26 -0500 From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: "Srivatsa S. Bhat" , Greg Kroah-Hartman , Thomas Backlund , Steve French Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, lsahlber@redhat.com, pshilov@microsoft.com, linux-cifs@vger.kernel.org Subject: Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed In-Reply-To: <47c8ba0a-f576-8ebe-1cb5-71ab80f77db7@csail.mit.edu> References: <20171031095530.520746935@linuxfoundation.org> <20171031095531.633196173@linuxfoundation.org> <97340c9a-0ea2-0d3d-cf26-58c799d76cae@mageia.org> <20171101151803.GB31285@kroah.com> <4ba67095-4075-688f-d3fb-157847aee4d9@csail.mit.edu> <47c8ba0a-f576-8ebe-1cb5-71ab80f77db7@csail.mit.edu> Date: Fri, 19 Jan 2018 14:23:22 +0100 Message-ID: <87lggux9rp.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi, "Srivatsa S. Bhat" writes: >> Any thoughts on what is the right fix for stable kernels? Mounting SMB3 >> shares works great on mainline (v4.15-rc5). It also works on 4.4.109 if >> I pass the sec=ntlmsspi option to the mount command (as opposed to the >> default: sec=ntlmssp). Please let me know if you need any other info. Make sure you have (in that order): db3b5474f462 ("CIFS: Fix NULL pointer deref on SMB2_tcon() failure") fe83bebc0522 ("SMB: fix leak of validate negotiate info response buffer") a2d9daad1d2d ("SMB: fix validate negotiate info uninitialised memory use") 4587eee04e2a ("SMB3: Validate negotiate request must always be signed") a821df3f1af7 ("cifs: fix NULL deref in SMB2_read") Does enabling CIFS_SMB311 changes anything? I also suspect some things assume encryption patches are in. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)