From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757929AbdDSACi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Apr 2017 20:02:38 -0400
Received: from anholt.net ([50.246.234.109]:46578 "EHLO anholt.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757821AbdDSACg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Apr 2017 20:02:36 -0400
From: Eric Anholt <eric@anholt.net>
To: Florian Fainelli <f.fainelli@gmail.com>,
        dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime.
In-Reply-To: <7906db2f-cfb8-e2e6-5869-b6e829dd8c6f@gmail.com>
References: <20170418191157.18517-1-eric@anholt.net> <20170418233805.15767-1-eric@anholt.net> <7906db2f-cfb8-e2e6-5869-b6e829dd8c6f@gmail.com>
User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Tue, 18 Apr 2017 17:02:33 -0700
Message-ID: <87lgqx463q.fsf@eliezer.anholt.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Florian Fainelli <f.fainelli@gmail.com> writes:

> On 04/18/2017 04:38 PM, Eric Anholt wrote:
>> For the Raspberry Pi's bindings, the power domain also implicitly
>> turns on the clock and deasserts reset, but for the new Cygnus port we
>> start representing the clock in the devicetree.
>>=20
>> v2: Document the clock-names property, check for -ENOENT for no clock
>>     in DT.
>>=20
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>
>> +	if (v3d->clk)
>> +		clk_disable_unprepare(v3d->clk);
>
> The clock API allows you to pass a NULL clk and do nothing in these
> cases which is what you seem to have done a few lines below, you could
> simplify these checks?

Sounds good.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlj2qRkACgkQtdYpNtH8
nugyAw/+IwPyvsAqzBnI2+ZGbHc/lJJszAJ6b4D4yTmCP2ZQJsQBlU/FLBGNJS3d
OR1ziEBj1ipCeC8P4rAv3dHGLoKvIB6kx6SFvogTrEcARRvxuM8rI1vuPZaxYwt+
w8JEnWD/JOqQowYpqyoimxZLnEcrr2JSSz0CCt688Wj5y8SBgBDQT17C9i7hTl6X
oL6OgcsDPcqLARughQEl15k5yKil/zYmEEKxGbbN2UwZ5fr4z2ZgQioWnQaV+Yn1
int+dQ/eQ0y1YQ2o+WL4XLmcNg4ZYwpFum0QZAE9ixJE79q1Yybz36jO0P5dbM2h
jnFq3HUucr2CSCkTIWIv3PPSU/EaKVh5PiyhTN96AS/Ovvd9WlI7ZZJ5YXk0+cHv
V8I3UfKhB5zum/zAnvvLMeWl9WX9WuHzin9G5XpM2HE8NnGCMSRns7sodcJeO6+f
RL8DBy2AQHCe4qFFBeT96uBJwu7DiDvLhFETwOsJa7cYfLwSy08EVd8xeqBiXfxU
v51GVW5BliNqPIll0EEorzrnIaI89e2tjHmR5V5kqbcceg1A6+eZ6RULZXV23ePY
wwkJVwaT1/8r1FxjE/rsMSSKx8E7aLP804VAUDUN+16J9aCh5AvrQ2823Neo2LZL
Z8jhV+hP/mwVuyvAziVnqEfTAPDyCfa+HU81/L5zKg/cfvER1mE=
=6nG5
-----END PGP SIGNATURE-----
--=-=-=--