From: Ed L Cashin <ecashin@coraid.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AOE: fix up the block device registration so that it actually works now.
Date: Wed, 19 Jan 2005 09:08:14 -0500 [thread overview]
Message-ID: <87llap5x69.fsf@coraid.com> (raw)
In-Reply-To: 20050119000935.GA22454@kroah.com
Greg KH <greg@kroah.com> writes:
> Ed, I need the following patch against the latest -bk tree in order to
> get the aoe code to load and work properly. Does it look good to you?
I'm having trouble seeing what's in -bk. I have a clone of
bk://linux.bkbits.net/linux-2.5, but when I "bk pull" there it says
"Nothing to pull." And my clone doesn't have all the aoe patches I've
seen get pushed to -bk.
...
> -------------
>
> AOE: fix up the block device registration so that it actually works now.
>
> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
>
> diff -Nru a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> --- a/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00
> +++ b/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00
> @@ -249,6 +249,7 @@
> aoeblk_exit(void)
> {
> kmem_cache_destroy(buf_pool_cache);
> + unregister_blkdev(AOE_MAJOR, DEVICE_NAME);
> }
The unregister_blkdev should already be in aoemain.c:aoe_exit.
static void
aoe_exit(void)
{
discover_timer(TKILL);
aoenet_exit();
unregister_blkdev(AOE_MAJOR, DEVICE_NAME);
aoechr_exit();
aoedev_exit();
aoeblk_exit(); /* free cache after de-allocating bufs */
}
> int __init
> diff -Nru a/drivers/block/aoe/aoemain.c b/drivers/block/aoe/aoemain.c
> --- a/drivers/block/aoe/aoemain.c 2005-01-18 16:06:57 -08:00
> +++ b/drivers/block/aoe/aoemain.c 2005-01-18 16:06:57 -08:00
> @@ -82,11 +82,6 @@
> ret = aoenet_init();
> if (ret)
> goto net_fail;
> - ret = register_blkdev(AOE_MAJOR, DEVICE_NAME);
> - if (ret < 0) {
> - printk(KERN_ERR "aoe: aoeblk_init: can't register major\n");
> - goto blkreg_fail;
> - }
>
> printk(KERN_INFO
> "aoe: aoe_init: AoE v2.6-%s initialised.\n",
Hmm. I'll try to send a patch against usb, since I can pull from
there.
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2005-01-19 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 0:09 [PATCH] AOE: fix up the block device registration so that it actually works now Greg KH
2005-01-19 14:08 ` Ed L Cashin [this message]
2005-01-19 21:56 ` Greg KH
2005-01-20 13:35 ` Ed L Cashin
2005-01-20 14:43 ` Greg KH
2005-01-19 20:43 ` Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87llap5x69.fsf@coraid.com \
--to=ecashin@coraid.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).