From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3747C38145 for ; Tue, 6 Sep 2022 07:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238738AbiIFHJ0 (ORCPT ); Tue, 6 Sep 2022 03:09:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232746AbiIFHJP (ORCPT ); Tue, 6 Sep 2022 03:09:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E8376E2FB; Tue, 6 Sep 2022 00:09:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBAA161355; Tue, 6 Sep 2022 07:09:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AAA1C433D6; Tue, 6 Sep 2022 07:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662448153; bh=OpnXg2yp5D94aJOko6Ai/kddMC46J9TfMxvX+Yijsho=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sSEWmu58xpxNoda7Jv8czDVQBvtwuupoctAaitgDLD+59eUrSNElAnMgyF9oa/yph aYqmZ5gqJ8VfXenlZum4JHyiSN9vS470g1/c/Ok+5mhq1gsKx/TRszvVdp1d9imRpu +bE9LF9mxDpUyDxRy2Zt/1P+jeReHRW2C6fD5FzQobHlK8m+6Ma9tWZimdngNcY6Qk PkL5xnQ7jirlmlJijeSF1w+yEfW2kkob7K/v6pY4rI+XAAmgYiPwGWC/Xc9YY75Nkr rg7dYPIbpy9B5WwA8e3dXRF8WlfNpptGmmR7MUP2fPnc+LYhhfQXNwrponYC6LXChw 3Ud+To4SJqUyA== Received: from 82-132-232-76.dab.02.net ([82.132.232.76] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oVShq-008Exn-S5; Tue, 06 Sep 2022 08:09:11 +0100 Date: Tue, 06 Sep 2022 08:09:14 +0100 Message-ID: <87mtbdq8rp.wl-maz@kernel.org> From: Marc Zyngier To: Dmitry Torokhov Cc: Alyssa Rosenzweig , Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Bjorn Helgaas , Hector Martin , Sven Peter , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 82.132.232.76 X-SA-Exim-Rcpt-To: dmitry.torokhov@gmail.com, alyssa@rosenzweig.io, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, marcan@marcan.st, sven@svenpeter.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Sep 2022 03:15:23 +0100, Dmitry Torokhov wrote: > > The driver allocates reset GPIO in apple_pcie_setup_port() but neither > releases the resource, nor uses devm API to have it released > automatically. > > Let's fix this by switching to devm API. While at it let's use generic > devm_fwnode_gpiod_get() instead of OF-specific gpiod_get_from_of_node() > - this will allow us top stop exporting the latter down the road. > > Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") > Signed-off-by: Dmitry Torokhov Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.