From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR
Date: Sun, 03 Apr 2022 21:58:07 +0200 [thread overview]
Message-ID: <87mth2kkhc.ffs@tglx> (raw)
In-Reply-To: <Yknsbp+zMh8Uev8+@zn.tnic>
On Sun, Apr 03 2022 at 20:50, Borislav Petkov wrote:
> On Sun, Apr 03, 2022 at 03:16:20PM +0200, Borislav Petkov wrote:
>> diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
>> index 9ccc2ea0ea00..4acc7959be6e 100644
>> --- a/arch/x86/kernel/cpu/mce/amd.c
>> +++ b/arch/x86/kernel/cpu/mce/amd.c
>> @@ -723,7 +723,7 @@ bool amd_mce_is_memory_error(struct mce *m)
>> }
>>
>> /* Extract [55:<lsb>] where lsb is the LS-*valid* bit of the address bits. */
>> -void smca_extract_err_addr(struct mce *m)
>> +void __always_inline smca_extract_err_addr(struct mce *m)
>
> Ok, flip those - the pedantic bot is not happy:
>
>>> arch/x86/kernel/cpu/mce/amd.c:726:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
> 726 | void __always_inline smca_extract_err_addr(struct mce *m)
> | ^~~~
>
> Needs to be
>
> __always_inline void
>
> whateva...
How is __always_inline supposed to work across compilation units w/o
LTO? The callsite is in core.c ...
Thanks,
tglx
next prev parent reply other threads:[~2022-04-03 19:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 19:33 [PATCH v4 0/3] x86/mce: Support extended MCA_ADDR address on SMCA systems Smita Koralahalli
2022-02-25 19:33 ` [PATCH v4 1/3] x86/mce: Avoid unnecessary padding in struct mce_bank Smita Koralahalli
2022-04-05 20:56 ` [tip: ras/core] " tip-bot2 for Smita Koralahalli
2022-02-25 19:33 ` [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR Smita Koralahalli
2022-03-31 13:24 ` Borislav Petkov
2022-04-03 13:16 ` Borislav Petkov
2022-04-03 18:50 ` Borislav Petkov
2022-04-03 19:58 ` Thomas Gleixner [this message]
2022-04-03 20:44 ` Borislav Petkov
2022-04-04 20:55 ` Smita Koralahalli
2022-04-04 21:56 ` Borislav Petkov
2022-02-25 19:33 ` [PATCH v4 3/3] x86/mce: Add support for Extended Physical Address MCA changes Smita Koralahalli
2022-03-11 21:00 ` [PATCH v4 0/3] x86/mce: Support extended MCA_ADDR address on SMCA systems Koralahalli Channabasappa, Smita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mth2kkhc.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).