From: ebiederm@xmission.com (Eric W. Biederman)
To: Alexey Gladkov <legion@kernel.org>
Cc: Sven Schnelle <svens@linux.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ucounts: add missing data type changes
Date: Mon, 26 Jul 2021 14:31:35 -0500 [thread overview]
Message-ID: <87mtq8kh2g.fsf@disp2133> (raw)
In-Reply-To: <20210726190619.kcks2gst562blvr4@example.org> (Alexey Gladkov's message of "Mon, 26 Jul 2021 21:06:19 +0200")
Alexey Gladkov <legion@kernel.org> writes:
> On Wed, Jul 21, 2021 at 02:52:33PM +0200, Sven Schnelle wrote:
>> commit f9c82a4ea89c3 ("Increase size of ucounts to atomic_long_t")
>> changed the data type of ucounts/ucounts_max to long, but missed to
>> adjust a few other places. This is noticeable on big endian platforms
>> from user space because the /proc/sys/user/max_*_names files all
>> contain 0.
>>
>> Fixes: f9c82a4ea89c ("Increase size of ucounts to atomic_long_t")
>> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
>
> Acked-by: Alexey Gladkov <legion@kernel.org>
>
> Eric, what do you think ?
At a quick skim it looks good. I was to swamped last week to pick it
up, but I plan on picking this up and getting it to Linus before
the next -rc release.
Eric
>> ---
>> fs/notify/fanotify/fanotify_user.c | 10 ++++++----
>> kernel/ucount.c | 16 ++++++++--------
>> 2 files changed, 14 insertions(+), 12 deletions(-)
>>
>> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
>> index 64864fb40b40..6576657a1a25 100644
>> --- a/fs/notify/fanotify/fanotify_user.c
>> +++ b/fs/notify/fanotify/fanotify_user.c
>> @@ -58,18 +58,20 @@ struct ctl_table fanotify_table[] = {
>> {
>> .procname = "max_user_groups",
>> .data = &init_user_ns.ucount_max[UCOUNT_FANOTIFY_GROUPS],
>> - .maxlen = sizeof(int),
>> + .maxlen = sizeof(long),
>> .mode = 0644,
>> - .proc_handler = proc_dointvec_minmax,
>> + .proc_handler = proc_doulongvec_minmax,
>> .extra1 = SYSCTL_ZERO,
>> + .extra2 = SYSCTL_INT_MAX,
>> },
>> {
>> .procname = "max_user_marks",
>> .data = &init_user_ns.ucount_max[UCOUNT_FANOTIFY_MARKS],
>> - .maxlen = sizeof(int),
>> + .maxlen = sizeof(long),
>> .mode = 0644,
>> - .proc_handler = proc_dointvec_minmax,
>> + .proc_handler = proc_doulongvec_minmax,
>> .extra1 = SYSCTL_ZERO,
>> + .extra2 = SYSCTL_INT_MAX,
>> },
>> {
>> .procname = "max_queued_events",
>> diff --git a/kernel/ucount.c b/kernel/ucount.c
>> index 87799e2379bd..f852591e395c 100644
>> --- a/kernel/ucount.c
>> +++ b/kernel/ucount.c
>> @@ -58,14 +58,14 @@ static struct ctl_table_root set_root = {
>> .permissions = set_permissions,
>> };
>>
>> -#define UCOUNT_ENTRY(name) \
>> - { \
>> - .procname = name, \
>> - .maxlen = sizeof(int), \
>> - .mode = 0644, \
>> - .proc_handler = proc_dointvec_minmax, \
>> - .extra1 = SYSCTL_ZERO, \
>> - .extra2 = SYSCTL_INT_MAX, \
>> +#define UCOUNT_ENTRY(name) \
>> + { \
>> + .procname = name, \
>> + .maxlen = sizeof(long), \
>> + .mode = 0644, \
>> + .proc_handler = proc_doulongvec_minmax, \
>> + .extra1 = SYSCTL_ZERO, \
>> + .extra2 = SYSCTL_INT_MAX, \
>> }
>> static struct ctl_table user_table[] = {
>> UCOUNT_ENTRY("max_user_namespaces"),
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-07-26 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 12:52 [PATCH v2] ucounts: add missing data type changes Sven Schnelle
2021-07-26 19:06 ` Alexey Gladkov
2021-07-26 19:31 ` Eric W. Biederman [this message]
2021-07-28 17:16 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtq8kh2g.fsf@disp2133 \
--to=ebiederm@xmission.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).