From: NeilBrown <neilb@suse.de>
To: Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.cz>,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: milan.opensource@gmail.com, lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fsync.2: ERRORS: add EIO and ENOSPC
Date: Thu, 10 Sep 2020 08:50:42 +1000 [thread overview]
Message-ID: <87mu1yk1j1.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <f4d38a20cb0f25b137fe07a7f43358ab3a459038.camel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Tue, Sep 08 2020, Jeff Layton wrote:
>
> Yep.
>
> My only comment is that there is nothing special about EIO and ENOSPC.
There are two type of errors that fsync can return.
EBADF EROFS EINVAL - these are usage errors.
EIO ENOSPC EDQUOT - these are functional failures.
So I would say there *is* something special about those errors, though
it isn't *very* special, and it isn't *just* those errors. EDQUOT should
be included in the list.
NeilBrown
> All errors are the same in this regard. Basically, issuing a new fsync
> after a failed one doesn't do any good. You need to redirty the pages
> first.
> --
> Jeff Layton <jlayton@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2020-09-10 2:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 7:13 [PATCH] fsync.2: ERRORS: add EIO and ENOSPC milan.opensource
2020-09-07 7:11 ` Michael Kerrisk (man-pages)
2020-09-08 11:27 ` Jan Kara
2020-09-08 16:10 ` Jeff Layton
2020-09-09 22:50 ` NeilBrown [this message]
2020-09-08 19:44 ` Jeff Layton
2020-09-09 10:53 ` Michael Kerrisk (man-pages)
2020-09-09 23:04 ` NeilBrown
2020-09-10 17:42 ` Jeff Layton
2020-09-16 23:25 ` NeilBrown
2020-09-17 7:01 ` Michael Kerrisk (man-pages)
2020-09-09 10:52 ` Michael Kerrisk (man-pages)
2020-09-09 11:21 ` Jan Kara
2020-09-09 11:58 ` Michael Kerrisk (man-pages)
2020-09-09 14:14 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu1yk1j1.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milan.opensource@gmail.com \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).