From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECEFC433DF for ; Tue, 30 Jun 2020 01:24:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09D1120760 for ; Tue, 30 Jun 2020 01:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbgF3BYu (ORCPT ); Mon, 29 Jun 2020 21:24:50 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:27174 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726481AbgF3BYu (ORCPT ); Mon, 29 Jun 2020 21:24:50 -0400 Date: 30 Jun 2020 10:24:48 +0900 X-IronPort-AV: E=Sophos;i="5.75,296,1589209200"; d="scan'208";a="50677645" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 30 Jun 2020 10:24:48 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 668654136A60; Tue, 30 Jun 2020 10:24:48 +0900 (JST) Message-ID: <87mu4lz6pt.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sameer Pujar Cc: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs In-Reply-To: <1e0cf6d1-bf4e-8808-5390-c8a3b7c7fe7e@nvidia.com> References: <1593233625-14961-1-git-send-email-spujar@nvidia.com> <1593233625-14961-13-git-send-email-spujar@nvidia.com> <874kqu1x70.wl-kuninori.morimoto.gx@renesas.com> <1e0cf6d1-bf4e-8808-5390-c8a3b7c7fe7e@nvidia.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sameer > > Maybe base issue for multiple codec support > > is that simple_for_each_link() is caring first codec only ? (snip) > Ideally I wanted to remove above two lines and allow empty codec > list. But some users may expect the parsing to fail if no 'Codec' is > found in the DAI link, hence did not remove above. If it is fine to > remove above two lines it would be simpler. The loop inside > simple_for_each_link() would anyway loop for each child node of DAI > link and simple_dai_link_of_dpcm() can parse each 'np'. Current simple-card is not assuming multi Codec, thus, we need to update it correctly, not quick-hack. I'm not sure how to do it, but it seems we need to update many functions to support it, not only simple-card driver. For example, simple-card-utils, soc-core, etc, etc... I'm not sure, this is just my guess. I'm happy if we can support it more easily :) But, if it was difficult to keep compatibility on simple-card, we/you need to have new one. Actually, I had a plan to create more flexible sound card driver, but it is not hi priority for me in these days. Thank you for your help !! Best regards --- Kuninori Morimoto