From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A51C433DF for ; Wed, 24 Jun 2020 19:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4713A2081A for ; Wed, 24 Jun 2020 19:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X9nwcbTv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391239AbgFXTYb (ORCPT ); Wed, 24 Jun 2020 15:24:31 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:53504 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387801AbgFXTYa (ORCPT ); Wed, 24 Jun 2020 15:24:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593026669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WwvLgGG2LaRCgwsWiAA6pHtAn5uRNCtZdPPhDv+Az8E=; b=X9nwcbTvKKLpBZpySp/od5OTZHog2dbeV4qS6FLUuGuXfbcgGIXwce4Zp9OhHCwvqK4rEj JOZBYaBdeJmzdpB7GHVurxUBVofOvM5ni2hUaTXXtxSDSiCiMZm7/K8CV4DbDHu4x5t6UM 58sAVoNrMsYETX+NpGRjE0wu2d+SFZ0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-uucXm7f8Nme8dccQphk9QQ-1; Wed, 24 Jun 2020 15:24:25 -0400 X-MC-Unique: uucXm7f8Nme8dccQphk9QQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A65A804003; Wed, 24 Jun 2020 19:24:23 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-18.ams2.redhat.com [10.36.113.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 485145C1BB; Wed, 24 Jun 2020 19:24:17 +0000 (UTC) From: Florian Weimer To: Mathieu Desnoyers Cc: carlos , Joseph Myers , Szabolcs Nagy , libc-alpha , Thomas Gleixner , Ben Maurer , Peter Zijlstra , Paul , Boqun Feng , Will Deacon , Dave Watson , Paul Turner , Rich Felker , linux-kernel , linux-api Subject: Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21) References: <20200622180803.1449-1-mathieu.desnoyers@efficios.com> <20200622180803.1449-2-mathieu.desnoyers@efficios.com> <87d05obl4w.fsf@oldenburg2.str.redhat.com> <1158112159.11628.1593025203438.JavaMail.zimbra@efficios.com> <87r1u48eix.fsf@oldenburg2.str.redhat.com> <1248023868.11643.1593026198678.JavaMail.zimbra@efficios.com> Date: Wed, 24 Jun 2020 21:24:15 +0200 In-Reply-To: <1248023868.11643.1593026198678.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Wed, 24 Jun 2020 15:16:38 -0400 (EDT)") Message-ID: <87mu4s8dy8.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mathieu Desnoyers: >> I think we should keep things simple on the glibc side for now and do >> this changes to the kernel headers first. > > Just to be sure I understand what you mean by "keep things simple", do you > recommend removing the following lines completely for now from sys/rseq.h ? > > /* Ensure the compiler supports rseq_align. */ > __rseq_static_assert (__rseq_alignof (struct rseq_cs) >= 32, "alignment"); > __rseq_static_assert (__rseq_alignof (struct rseq) >= 32, "alignment"); Yes, that's what I meant. Thanks, Florian