From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
mripard@kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, "Deucher\,
Alexander" <alexander.deucher@amd.com>
Cc: "open list\:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100
Date: Wed, 08 Apr 2020 10:22:37 +0300 [thread overview]
Message-ID: <87mu7migqq.fsf@intel.com> (raw)
In-Reply-To: <1F57CA05-3E23-4CA8-A138-6785906ED465@canonical.com>
On Tue, 07 Apr 2020, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>> On Mar 27, 2020, at 19:03, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>>
>> Hi,
>>
>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>>>
>>> There's another OLED panel needs to use DPCD aux interface to control
>>> backlight.
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1860303
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>
>> Would it be possible to review this?
>> I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.
>
> Another gentle ping...
Can't really review, but if you say that's needed...
Acked-by: Jani Nikula <jani.nikula@intel.com>
>
>>
>> Kai-Heng
>>
>>> ---
>>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>>> index 8ba4531e808d..a0d4314663de 100644
>>> --- a/drivers/gpu/drm/drm_dp_helper.c
>>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>>> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>>> * only supports DPCD backlight controls
>>> */
>>> { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>> + /* HP Spectre x360 Convertible 13t-aw100 */
>>> + { MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>> /*
>>> * Some Dell CML 2020 systems have panels support both AUX and PWM
>>> * backlight control, and some only support AUX backlight control. All
>>> --
>>> 2.17.1
>>>
>>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2020-04-08 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 5:35 [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100 Kai-Heng Feng
2020-03-27 11:03 ` Kai-Heng Feng
2020-04-07 6:07 ` Kai-Heng Feng
2020-04-08 7:22 ` Jani Nikula [this message]
2020-10-07 7:01 ` Kai-Heng Feng
2021-01-18 13:56 ` Niccolo Maggioni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu7migqq.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).