[PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Kuninori Morimoto]

Hi Greg

I'm posting this patch from few month ago,
but it seems SH ML maintainer is not working in these days...

I'm not sure who can handle this patch in this case,
but is it possible to consider about it ?

Thank you for your help !!
Best regards
---
Kuninori Morimoto

[PATCH] sh: kgdb: Mark expected switch fall-throughs

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Mark switch cases where we are expecting to fall through.

This patch fixes the following error:

LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (kgdb_hex2long(&ptr, &addr))
^
LINUX/arch/sh/kernel/kgdb.c:269:2: note: here
case 'D':
^~~~

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
---
 arch/sh/kernel/kgdb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c
index 6d61f8c..0d5f3c9 100644
--- a/arch/sh/kernel/kgdb.c
+++ b/arch/sh/kernel/kgdb.c
@@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
 		ptr = &remcomInBuffer[1];
 		if (kgdb_hex2long(&ptr, &addr))
 			linux_regs->pc = addr;
+		/* fallthrough */
 	case 'D':
 	case 'k':
 		atomic_set(&kgdb_cpu_doing_single_step, -1);
-- 
2.7.4

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Geert Uytterhoeven]

Hi Morimoto-san,

On Tue, Dec 10, 2019 at 1:26 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> I'm posting this patch from few month ago,
> but it seems SH ML maintainer is not working in these days...
>
> I'm not sure who can handle this patch in this case,
> but is it possible to consider about it ?

You may want to CC Andrew Morton <akpm@linux-foundation.org>, who
tends to pick up patches for non-responsive architecture maintainers.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Kuninori Morimoto]

Hi Geert

> > I'm posting this patch from few month ago,
> > but it seems SH ML maintainer is not working in these days...
> >
> > I'm not sure who can handle this patch in this case,
> > but is it possible to consider about it ?
> 
> You may want to CC Andrew Morton <akpm@linux-foundation.org>, who
> tends to pick up patches for non-responsive architecture maintainers.

Yeah, indeed.
Thanks, will do soon

Thank you for your help !!
Best regards
---
Kuninori Morimoto

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Rob Landley]

On 12/9/19 6:26 PM, Kuninori Morimoto wrote:
> 
> Hi Greg
> 
> I'm posting this patch from few month ago,
> but it seems SH ML maintainer is not working in these days...

There's two of them and they both are? (I spoke to Rich on IRC last week?)

Rob

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Yoshinori Sato]

On Wed, 11 Dec 2019 07:28:43 +0900,
Gustavo A. R. Silva wrote:
> 
> Hi,
> 
> On 12/10/19 02:38, Kuninori Morimoto wrote:
> > 
> > Hi Andrew
> > 
> > I'm posting this patch from few month ago,
> > but it seems SH maintainer is not working in these days...
> > 
> > Is it possible to consider about it ?
> > SH compile will be error without this patch.
> > 
> 
> I've added this to my -next tree and will consider it for 5.5-rc2.
> 
> Thanks!
> --
> Gustavo
> 

Thanks.
I was going to work tonight or tomorrow.
Dose nothing if merged.

--
Yoshinori Sato

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

On 12/10/19 02:38, Kuninori Morimoto wrote:
> 
> Hi Andrew
> 
> I'm posting this patch from few month ago,
> but it seems SH maintainer is not working in these days...
> 
> Is it possible to consider about it ?
> SH compile will be error without this patch.
> 

I've added this to my -next tree and will consider it for 5.5-rc2.

Thanks!
--
Gustavo

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Rob Landley]

On 12/10/19 2:12 PM, Rob Landley wrote:
> On 12/10/19 2:38 AM, Kuninori Morimoto wrote:
>>
>> Hi Andrew
>>
>> I'm posting this patch from few month ago,
>> but it seems SH maintainer is not working in these days...
> 
> Again, I dunno where you're getting that.
> 
> (Me, I removed the -Werror...)

In fact I looked it up, _I_ didn't remove the -Werror, Rich acked a patch
removing the -Werror back in August:

  https://www.spinics.net/lists/linux-sh/msg55405.html

Rob

Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Rob Landley]

On 12/10/19 2:38 AM, Kuninori Morimoto wrote:
> 
> Hi Andrew
> 
> I'm posting this patch from few month ago,
> but it seems SH maintainer is not working in these days...

Again, I dunno where you're getting that.

(Me, I removed the -Werror...)

Rob

[PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Kuninori Morimoto]

Hi Andrew

I'm posting this patch from few month ago,
but it seems SH maintainer is not working in these days...

Is it possible to consider about it ?
SH compile will be error without this patch.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

[PATCH][resend] sh: kgdb: Mark expected switch fall-throughs

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Mark switch cases where we are expecting to fall through.

This patch fixes the following error:

LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (kgdb_hex2long(&ptr, &addr))
^
LINUX/arch/sh/kernel/kgdb.c:269:2: note: here
case 'D':
^~~~

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
---

- nothing happen in 1 month...

 arch/sh/kernel/kgdb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c
index 6d61f8c..0d5f3c9 100644
--- a/arch/sh/kernel/kgdb.c
+++ b/arch/sh/kernel/kgdb.c
@@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
 		ptr = &remcomInBuffer[1];
 		if (kgdb_hex2long(&ptr, &addr))
 			linux_regs->pc = addr;
+		/* fallthrough */
 	case 'D':
 	case 'k':
 		atomic_set(&kgdb_cpu_doing_single_step, -1);
-- 
2.7.4