From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Imre Kaloz <kaloz@openwrt.org>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] Linksys WRT3200ACM (Rango) support
Date: Tue, 23 May 2017 17:22:05 +0200 [thread overview]
Message-ID: <87mva3wqci.fsf@free-electrons.com> (raw)
In-Reply-To: <20170521124903.11050-1-ralph.sennhauser@gmail.com> (Ralph Sennhauser's message of "Sun, 21 May 2017 14:48:49 +0200")
Hi Ralph,
On dim., mai 21 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
> Hi everyone
>
> This series adds support for the latest model in Linksys WRT AC series
> of routers. The WRT3200ACM was released in October 2016 and the code
> name is Rango.
>
> As it comes with a flash chip twice as big the dts Imre Kaloz has
> written for OpenWrt isn't based on armada-385-linksys.dtsi to avoid
> conflicts. Nonetheless its part of the same family, so the bigger part
> of this series is dedicated to reorganize / modernize / cleanup /
> somewhat future proof the armada-385-linksys.dtsi and it's dependants so
> the dts for the Rango addition can use the same dtsi.
>
> Key differences to the earlier Armada-385 based devices in the series is
> a bigger flash chip, next generation wireless modules in the mini pcie
> slots as well as a Marvell SD8887. Finally the CPU is clocked at 1866
> GHz by default.
>
> The series depends on Linux 4.12-rc1 and is targeted for 4.13.
>
> Ralph
>
>
I applied the 11 first patches on mvebu/dt. I added the "Signed-off-by"
from Imre Kaloz <kaloz@openwrt.org> on all of them and the "Reviewed-by"
from Andrew Lunn <andrew@lunn.ch> when approriate.
I also did the following things:
> Ralph Sennhauser (13):
> ARM: dts: armada-385-linksys: flatten dtsi
> ARM: dts: armada-385-linksys: label nodes
Fixed typo pointed by Andrew
> ARM: dts: armada-385-linksys: flatten dependants
Fixed typo pointed by Andrew
Something that I didn't change is the word "dependants", I don't know
what do you means exactly. But not being native speaker I maybe missed
something.
> ARM: dts: armada-385-linksys: drop redundant properties in dependants
> ARM: dts: armada-385-linksys: bm pools by label order
> ARM: dts: armada-385-linksys: usb3 label cleanup
I applied this one because I found Ralph explanation convincing about not
modifying the ABI
> ARM: dts: armada-385-linksys: drop leagcy DSA bindings
Fixed typo in title and commit log
> ARM: dts: armada-385-linksys: use binary unit prefixes
As Ralph I prefer that we use normalized unit. Especially when we use
MiB or KiB then we are sure that we use a power of 2, whereas when we
see KB we don't know if it is 1024B or 1000B.
> ARM: dts: armada-385-linksys: partition layout is board specific
> ARM: dts: armada-385-linksys: group pins in pinctrl
> ARM: dts: armada-385-linksys: fixup button node names
> clk: mvebu: add support for 1866MHz variants
I didn't apply this one as it must go through the clk tree and there was
also a pending question from Andrew.
> ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)
For this last one do you finally agree to use "non-removable" instead of
"broken-cd" ?
Gregory
>
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 187 +++++++-----
> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 187 +++++++-----
> arch/arm/boot/dts/armada-385-linksys-rango.dts | 203 +++++++++++++
> arch/arm/boot/dts/armada-385-linksys-shelby.dts | 187 +++++++-----
> arch/arm/boot/dts/armada-385-linksys.dtsi | 362 ++++++++----------------
> drivers/clk/mvebu/armada-38x.c | 3 +-
> 7 files changed, 695 insertions(+), 435 deletions(-)
> create mode 100644 arch/arm/boot/dts/armada-385-linksys-rango.dts
>
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-05-23 15:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 12:48 [PATCH 00/13] Linksys WRT3200ACM (Rango) support Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 01/13] ARM: dts: armada-385-linksys: flatten dtsi Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 02/13] ARM: dts: armada-385-linksys: label nodes Ralph Sennhauser
2017-05-22 14:49 ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants Ralph Sennhauser
2017-05-22 14:51 ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 04/13] ARM: dts: armada-385-linksys: drop redundant properties in dependants Ralph Sennhauser
2017-05-22 14:52 ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 05/13] ARM: dts: armada-385-linksys: bm pools by label order Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 06/13] ARM: dts: armada-385-linksys: usb3 label cleanup Ralph Sennhauser
2017-05-22 14:55 ` Andrew Lunn
2017-05-22 18:13 ` Ralph Sennhauser
2017-05-21 12:48 ` [PATCH 07/13] ARM: dts: armada-385-linksys: drop leagcy DSA bindings Ralph Sennhauser
2017-05-22 14:55 ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes Ralph Sennhauser
2017-05-22 15:00 ` Andrew Lunn
2017-05-22 18:24 ` Ralph Sennhauser
2017-05-23 8:33 ` Ralph Sennhauser
2017-05-23 12:02 ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 09/13] ARM: dts: armada-385-linksys: partition layout is board specific Ralph Sennhauser
2017-05-23 12:04 ` Andrew Lunn
2017-05-21 12:48 ` [PATCH 10/13] ARM: dts: armada-385-linksys: group pins in pinctrl Ralph Sennhauser
2017-05-23 12:06 ` Andrew Lunn
2017-05-21 12:49 ` [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names Ralph Sennhauser
2017-05-23 12:07 ` Andrew Lunn
2017-05-21 12:49 ` [PATCH 12/13] clk: mvebu: add support for 1866MHz variants Ralph Sennhauser
2017-05-23 12:15 ` Andrew Lunn
2017-05-23 19:55 ` Ralph Sennhauser
2017-05-21 12:49 ` [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango) Ralph Sennhauser
2017-05-23 12:18 ` Andrew Lunn
2017-05-23 12:25 ` Andrew Lunn
2017-05-23 20:04 ` Ralph Sennhauser
2017-05-22 18:42 ` [PATCH 00/13] Linksys WRT3200ACM (Rango) support Imre Kaloz
2017-05-23 15:22 ` Gregory CLEMENT [this message]
2017-05-23 16:11 ` Ralph Sennhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mva3wqci.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=ralph.sennhauser@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).