From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbcHHKtr (ORCPT ); Mon, 8 Aug 2016 06:49:47 -0400 Received: from mga02.intel.com ([134.134.136.20]:1380 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcHHKtq (ORCPT ); Mon, 8 Aug 2016 06:49:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,489,1464678000"; d="scan'208";a="1021569026" From: Alexander Shishkin To: Peter Zijlstra , Mathieu Poirier Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() In-Reply-To: <20160804171903.GV6862@twins.programming.kicks-ass.net> References: <1469742143-22245-1-git-send-email-mathieu.poirier@linaro.org> <1469742143-22245-3-git-send-email-mathieu.poirier@linaro.org> <20160804171903.GV6862@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 08 Aug 2016 13:49:40 +0300 Message-ID: <87mvknmt6j.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Thu, Jul 28, 2016 at 03:42:19PM -0600, Mathieu Poirier wrote: >> Some information, like driver specific configuration, is found >> in the hw_perf_event structure. As such pass a 'struct perf_event' >> to function setup_aux() rather than just the CPU number so that >> individual drivers can make the right configuration when setting >> up a session. >> >> Signed-off-by: Mathieu Poirier >> Cc: Alexander Shishkin > > Yeah, no objection to this. Sure, but I'd like a commit message that actually describes *what* information and *why*. Regards, -- Alex