linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: David Cohen <david.a.cohen@intel.com>, dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, David Cohen <david.a.cohen@intel.com>
Subject: Re: [PATCH] MODSIGN: do not send garbage to stderr when enabling modules signature
Date: Tue, 09 Apr 2013 12:57:53 +0930	[thread overview]
Message-ID: <87mwt88jt2.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1365457436-5753-1-git-send-email-david.a.cohen@intel.com>

David Cohen <david.a.cohen@intel.com> writes:
> openssl may send garbage to stderr when generating X.509 key pair for
> modules signature regardless there was an error or not. It makes more
> difficult to create scripts based on kernel error/warning messages.
> This patch makes sure openssl logs go to default stdout.
>
> Signed-off-by: David Cohen <david.a.cohen@intel.com>

Can you please give an example of the "garbage" in your commit message,
or is it binary?

Thanks,
Rusty,.

> ---
>  kernel/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index bbde5f1..5a51e6c 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -175,7 +175,7 @@ signing_key.priv signing_key.x509: x509.genkey
>  	openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) -days 36500 \
>  		-batch -x509 -config x509.genkey \
>  		-outform DER -out signing_key.x509 \
> -		-keyout signing_key.priv
> +		-keyout signing_key.priv 2>&1
>  	@echo "###"
>  	@echo "### Key pair generated."
>  	@echo "###"
> -- 
> 1.7.10.4

  reply	other threads:[~2013-04-09  3:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 21:43 [PATCH] MODSIGN: do not send garbage to stderr when enabling modules signature David Cohen
2013-04-09  3:27 ` Rusty Russell [this message]
2013-04-09 21:29   ` David Cohen
2013-04-10 10:32 Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwt88jt2.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=david.a.cohen@intel.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).