From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@zip.com.au>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Linus Torvalds <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] smarter atime updates
Date: Fri, 30 Nov 2001 18:45:29 +0900 [thread overview]
Message-ID: <87n1144mo6.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <3C072279.D346CD09@zip.com.au>
In-Reply-To: <3C072279.D346CD09@zip.com.au>
Hi,
Andrew Morton <akpm@zip.com.au> writes:
> mark_inode_dirty() is quite expensive for journalling filesystems,
> and we're calling it a lot more than we need to.
>
> --- linux-2.4.17-pre1/fs/inode.c Mon Nov 26 11:52:07 2001
> +++ linux-akpm/fs/inode.c Thu Nov 29 21:53:02 2001
> @@ -1187,6 +1187,8 @@ void __init inode_init(unsigned long mem
>
> void update_atime (struct inode *inode)
> {
> + if (inode->i_atime == CURRENT_TIME)
> + return;
> if ( IS_NOATIME (inode) ) return;
> if ( IS_NODIRATIME (inode) && S_ISDIR (inode->i_mode) ) return;
> if ( IS_RDONLY (inode) ) return;
in include/linux/fs.h:
#define UPDATE_ATIME(inode) \
do { \
if ((inode)->i_atime != CURRENT_TIME) \
update_atime (inode); \
} while (0)
How about this macro? (add likely()?)
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2001-11-30 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-30 6:08 [patch] smarter atime updates Andrew Morton
2001-11-30 9:45 ` OGAWA Hirofumi [this message]
2001-11-30 9:56 ` Andrew Morton
2001-11-30 10:40 ` OGAWA Hirofumi
2001-11-30 22:34 ` H. Peter Anvin
2001-11-30 15:44 ` Marcelo Tosatti
2001-11-30 17:29 ` Chris Mason
2001-11-30 20:03 ` Robert Love
2001-11-30 21:52 ` Andreas Dilger
2001-11-30 21:50 ` Linus Torvalds
2001-11-30 22:30 ` Simon Kirby
2001-11-30 23:31 ` H. Peter Anvin
2001-12-01 9:22 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87n1144mo6.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).