From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10678C433F5 for ; Fri, 3 Dec 2021 14:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381357AbhLCOM7 (ORCPT ); Fri, 3 Dec 2021 09:12:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28475 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352554AbhLCOM5 (ORCPT ); Fri, 3 Dec 2021 09:12:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638540572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Th3/AwwdNWFRMVyXQbUB5Zn699vPcry9PjQt24tDZNs=; b=BnvbZmSxAKuvvWFBMi779uHrkQGll0hXImSlHmkSWpO7ywlwSlsIBz6Kj5TGGYEcqZt+Ws 1EKfjkacukyWiUhKPTrWxTecZc1X4Dgjgm5kwpcHdAXK9vAbKkpY+WyWSaAvdKDHI3nlDq ESj7hRUa5t32cu+XiS1ieiPE9Q5u/nA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-UcAKOW5lOB6eeNJAzHZ6kA-1; Fri, 03 Dec 2021 09:09:31 -0500 X-MC-Unique: UcAKOW5lOB6eeNJAzHZ6kA-1 Received: by mail-wm1-f71.google.com with SMTP id m14-20020a05600c3b0e00b0033308dcc933so1418089wms.7 for ; Fri, 03 Dec 2021 06:09:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Th3/AwwdNWFRMVyXQbUB5Zn699vPcry9PjQt24tDZNs=; b=cqQ8IevQyxq3Q4dgHRjuwFbj+5H93InHAGJyL8DuYS0uPKRya+gHu/UtyIQZnqDUET a5dSrbODQsA6WyS940ZgJ5bLlHv1vGFW1a6RpFkmqT6ftPIjwO56kWdY1lWfLAJg/GnD Hjv6jyABIXzT++VAge4CCyzxiuBANNwA9NUlQnCLYJUTKnuh+MAO0ueu3U9xGlQd0vQl zaaqan0V8dNT0p4ouzwjDs52X/Xk2uUAltQhS9PY3mRDlBIODU8sWhZEK1rJMrN9/Jhl Xbob+WNnwW1i+pZ9zsH1FKfiUOiur/MZl1K8iTOJsar4lzzUChNtW/DbIEQVPPvGxOCj ogsg== X-Gm-Message-State: AOAM530Bx3FY3x8bfJkvy4lGQ0j0Vz2vEkQkBrovxBffxahgKWyAA1hs MBJkYIYamEcdgSTVrHyPo00v5KlxeZtzN+I8C4t1JvVrxip8moZ43oenFP8Olu13kIvhsPmARFT 9TqxjKodDpAnfk8i6rQYPpoqw X-Received: by 2002:adf:e2c5:: with SMTP id d5mr21726925wrj.338.1638540569912; Fri, 03 Dec 2021 06:09:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwn8SCemCKl3G0iSjXXF2Z8BcbWnjoIe4SW0+H1SuKLyllcsxQUH/Bt1H7vpADvQabw8WfPDw== X-Received: by 2002:adf:e2c5:: with SMTP id d5mr21726875wrj.338.1638540569626; Fri, 03 Dec 2021 06:09:29 -0800 (PST) Received: from fedora (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id f15sm3497480wmg.30.2021.12.03.06.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 06:09:29 -0800 (PST) From: Vitaly Kuznetsov To: "Michael Kelley (LINUX)" , Sean Christopherson Cc: Wanpeng Li , Jim Mattson , Joerg Roedel , "kvm@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ajay Garg , Paolo Bonzini , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Arnd Bergmann Subject: Re: ** POTENTIAL FRAUD ALERT - RED HAT ** RE: [PATCH v2 8/8] KVM: x86: Add checks for reserved-to-zero Hyper-V hypercall fields In-Reply-To: References: <20211030000800.3065132-1-seanjc@google.com> <20211030000800.3065132-9-seanjc@google.com> <87v91cjhch.fsf@vitty.brq.redhat.com> Date: Fri, 03 Dec 2021 15:09:27 +0100 Message-ID: <87o85x7pbc.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael Kelley (LINUX)" writes: > From: Sean Christopherson Sent: Wednesday, December 1, 2021 6:13 PM >> >> On Mon, Nov 01, 2021, Vitaly Kuznetsov wrote: >> > Sean Christopherson writes: >> > >> > > Add checks for the three fields in Hyper-V's hypercall params that must >> > > be zero. Per the TLFS, HV_STATUS_INVALID_HYPERCALL_INPUT is returned if >> > > "A reserved bit in the specified hypercall input value is non-zero." >> > > >> > > Note, the TLFS has an off-by-one bug for the last reserved field, which >> > > it defines as being bits 64:60. The same section states "The input field >> > > 64-bit value called a hypercall input value.", i.e. bit 64 doesn't >> > > exist. >> > >> > This version are you looking at? I can't see this issue in 6.0b >> >> It's the web-based documentation, the 6.0b PDF indeed does not have the same bug. >> >> https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/hypercall-interface#hypercall-inputs > > Did you (or Vitaly) file a bug report on this doc issue? If not, I can do so. > Done, https://github.com/MicrosoftDocs/Virtualization-Documentation/pull/1682 -- Vitaly