From: Kalle Valo <kvalo@codeaurora.org>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linux-mmc@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [PATCH v8 00/24] wfx: get out from the staging area
Date: Tue, 05 Oct 2021 20:49:37 +0300 [thread overview]
Message-ID: <87o883e4zy.fsf@codeaurora.org> (raw)
In-Reply-To: <2810333.gDgIz5hftg@pc-42> (=?utf-8?B?IkrDqXLDtG1l?= Pouiller"'s message of "Tue, 05 Oct 2021 18:22:31 +0200")
Jérôme Pouiller <jerome.pouiller@silabs.com> writes:
> On Tuesday 5 October 2021 16:15:22 CEST Kalle Valo wrote:
>> Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:
>>
>> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> [...]
>> > v8:
>> > - Change the way the DT is handled. The user can now specify the name of
>> > the board (= chip + antenna) he use. It easier for board designers to
>> > add new entries. I plan to send a PR to linux-firmware to include PDS
>> > files of the developpement boards belong the firmware (I also plan to
>> > relocate these file into wfx/ instead of silabs/). (Kalle, Pali)
>> > - Prefix visible functions and structs with "wfx_". I mostly kept the
>> > code under 80 columns. (Kalle, Pali, Greg)
>> > - Remove support for force_ps_timeout for now. (Kalle)
>> > - Fix licenses of Makefile, Kconfig and hif_api*.h. (Kalle)
>> > - Do not mix and match endianess in struct hif_ind_startup. (Kalle)
>> > - Remove magic values. (Kalle)
>> > - Use IS_ALIGNED(). (BTW, PTR_IS_ALIGNED() does not exist?) (Kalle)
>> > - I have also noticed that some headers files did not declare all the
>> > struct they used.
>> >
>> > These issues remain (I hope they are not blockers):
>> > - I have currently no ideas how to improve/simplify the parsing PDS file.
>> > (Kalle)
>>
>> For the PDS file problem it would help if you could actually describe
>> what the firmware requires/needs and then we can start from that. I had
>> some questions about this in v7 but apparently you missed those.
>
> Did you received this reply[1]?
>
> [1]: https://lore.kernel.org/all/2723787.uDASXpoAWK@pc-42/
I did and I even made further questions:
https://lore.kernel.org/all/87k0ixj5vn.fsf@codeaurora.org/
Can we please continue the discussion on that thread instead of passing
out lore links to each other :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-05 17:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 13:53 [PATCH v8 00/24] wfx: get out from the staging area Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 02/24] dt-bindings: introduce silabs,wfx.yaml Jerome Pouiller
2021-10-05 22:45 ` Rob Herring
2021-10-05 13:53 ` [PATCH v8 03/24] wfx: add Makefile/Kconfig Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 04/24] wfx: add wfx.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 05/24] wfx: add main.c/main.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 06/24] wfx: add bus.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 07/24] wfx: add bus_spi.c Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 08/24] wfx: add bus_sdio.c Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 09/24] wfx: add hwio.c/hwio.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 10/24] wfx: add fwio.c/fwio.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 11/24] wfx: add bh.c/bh.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 12/24] wfx: add hif_api_*.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 13/24] wfx: add hif_tx*.c/hif_tx*.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 14/24] wfx: add key.c/key.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 15/24] wfx: add hif_rx.c/hif_rx.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 16/24] wfx: add data_rx.c/data_rx.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 17/24] wfx: add queue.c/queue.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 18/24] wfx: add data_tx.c/data_tx.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 19/24] wfx: add sta.c/sta.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 20/24] wfx: add scan.c/scan.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 21/24] wfx: add debug.c/debug.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 22/24] wfx: add traces.h Jerome Pouiller
2021-10-05 13:53 ` [PATCH v8 23/24] wfx: remove from the staging area Jerome Pouiller
2021-10-05 13:54 ` [PATCH v8 24/24] wfx: get out " Jerome Pouiller
2021-10-05 14:15 ` [PATCH v8 00/24] " Kalle Valo
2021-10-05 16:22 ` Jérôme Pouiller
2021-10-05 17:49 ` Kalle Valo [this message]
2021-10-05 14:20 ` Kalle Valo
2021-10-05 15:51 ` Jérôme Pouiller
2021-10-07 8:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o883e4zy.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).