From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD7AC4320A for ; Wed, 18 Aug 2021 11:19:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3868B610A3 for ; Wed, 18 Aug 2021 11:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235465AbhHRLUD (ORCPT ); Wed, 18 Aug 2021 07:20:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:56902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233798AbhHRLUA (ORCPT ); Wed, 18 Aug 2021 07:20:00 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D068C6109E; Wed, 18 Aug 2021 11:19:25 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mGJbP-005jkk-Lh; Wed, 18 Aug 2021 12:19:23 +0100 Date: Wed, 18 Aug 2021 12:19:23 +0100 Message-ID: <87o89vroec.wl-maz@kernel.org> From: Marc Zyngier To: Saravana Kannan , Lee Jones , Neil Armstrong Cc: Andrew Lunn , Kevin Hilman , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-arm-kernel , open list , netdev , Android Kernel Team Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module In-Reply-To: References: <87r1hwwier.wl-maz@kernel.org> <7h7diwgjup.fsf@baylibre.com> <87im0m277h.wl-maz@kernel.org> <87sfzpwq4f.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: saravanak@google.com, lee.jones@linaro.org, narmstrong@baylibre.com, andrew@lunn.ch, khilman@baylibre.com, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Aug 2021 19:12:34 +0100, Saravana Kannan wrote: > > On Tue, Aug 17, 2021 at 12:24 AM Lee Jones wrote: > > > > On Mon, 16 Aug 2021, Saravana Kannan wrote: > > > > > > I sent out the proper fix as a series: > > > > > > https://lore.kernel.org/lkml/20210804214333.927985-1-saravanak@google.com/T/#t > > > > > > > > > > > > Marc, can you give it a shot please? > > > > > > > > > > > > -Saravana > > > > > > > > > > Superstar! Thanks for taking the time to rectify this for all of us. > > > > > > > > Just to clarify: > > > > > > > > Are we waiting on a subsequent patch submission at this point? > > > > > > Not that I'm aware of. Andrew added a "Reviewed-by" to all 3 of my > > > proper fix patches. I didn't think I needed to send any newer patches. > > > Is there some reason you that I needed to? > > > > Actually, I meant *this* patch. > > I think it'll be nice if Neil addresses the stuff Marc mentioned > (ideally) using the macros I suggested. Not sure if Marc is waiting on > that though. Marc also probably wants my mdio-mux series to merge > first before he takes this patch. So that it doesn't break networking > in his device. Yup. Two things need to happen here: - the MDIO fixes must be merged (I think they are queued, from what I can see) - the irqchip patch must be fixed so that the driver cannot be unloaded (Saravana did explain what needs to be done). Once these two condition are met, I'll happily take this patch. M. -- Without deviation from the norm, progress is not possible.