From: Kalle Valo <kvalo@codeaurora.org>
To: Reto Schneider <rs@hqv.ch>
Cc: chris.chiu@canonical.com, code@reto-schneider.ch,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jes.sorensen@gmail.com,
davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v2] rtl8xxxu: Fix the handling of TX A-MPDU aggregation
Date: Fri, 06 Aug 2021 15:31:52 +0300 [thread overview]
Message-ID: <87o8aabvpj.fsf@codeaurora.org> (raw)
In-Reply-To: <26f85a9f-552d-8420-0010-f5cda70d3a00@hqv.ch> (Reto Schneider's message of "Fri, 6 Aug 2021 12:03:18 +0200")
Reto Schneider <rs@hqv.ch> writes:
> On 8/4/21 17:13, chris.chiu@canonical.com wrote:
>> The TX A-MPDU aggregation is not handled in the driver since the
>> ieee80211_start_tx_ba_session has never been started properly.
>> Start and stop the TX BA session by tracking the TX aggregation
>> status of each TID. Fix the ampdu_action and the tx descriptor
>> accordingly with the given TID.
>
> I'd like to test this but I am not sure what to look for (before and
> after applying the patch).
Thanks, testing feedback is always very much appreciated.
> What should I look for when looking at the (sniffed) Wireshark traces?
From my (maintainer) point of view most important is that there are no
regressions visible to users, for example no data stalls, crashes or
anything like that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-08-06 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 15:13 [PATCH v2] rtl8xxxu: Fix the handling of TX A-MPDU aggregation chris.chiu
2021-08-06 9:03 ` Kalle Valo
2021-08-06 10:03 ` Reto Schneider
2021-08-06 12:31 ` Kalle Valo [this message]
2021-08-09 12:59 ` Chris Chiu
2021-08-21 18:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8aabvpj.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=chris.chiu@canonical.com \
--cc=code@reto-schneider.ch \
--cc=davem@davemloft.net \
--cc=jes.sorensen@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rs@hqv.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).