From: John Ogness <john.ogness@linutronix.de>
To: Joe Perches <joe@perches.com>,
chao.qin@intel.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, bigeasy@linutronix.de,
tglx@linutronix.de, rostedt@goodmis.org
Cc: mgross@linux.intel.com, paul.mei@intel.com, lili.li@intel.com
Subject: Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush()
Date: Tue, 20 Jul 2021 16:09:21 +0206 [thread overview]
Message-ID: <87o8axm6ae.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <ea6c6a2b5482d62038d7d0a1d46b87665051222f.camel@perches.com>
On 2021-07-20, Joe Perches <joe@perches.com> wrote:
> Logic continuations are typically at the end of the previous line.
> And there are few too many parentheses for my taste.
>
> Maybe exceed 80 columns in a single line
>
> may_sleep = preemptible() && !in_softirq() && system_state >= SYSTEM_RUNNING;
>
> or align the continuation
>
> may_sleep = (preemptible() && !in_softirq() &&
> system_state >= SYSTEM_RUNNING);
>
> or use individual lines
>
> may_sleep = (preemptible() &&
> !in_softirq() &&
> system_state >= SYSTEM_RUNNING);
The kernel now has a 100-column policy, but I decided to go with this
third variant for easy reading.
Chao Qin, your patch will be part of the next PREEMPT_RT release. Thank
you.
John Ogness
next prev parent reply other threads:[~2021-07-20 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 2:26 [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush() chao.qin
2021-07-19 14:55 ` John Ogness
2021-07-30 14:01 ` Sebastian Andrzej Siewior
2021-07-30 14:46 ` John Ogness
2021-08-02 6:08 ` Qin, Chao
2021-08-02 6:48 ` Sebastian Andrzej Siewior
2021-07-20 11:55 ` Joe Perches
2021-07-20 14:03 ` John Ogness [this message]
2021-07-21 1:42 ` Qin, Chao
2021-08-05 3:01 ` Qin, Chao
2021-08-05 12:21 ` John Ogness
2021-08-05 16:12 ` Steven Rostedt
2021-08-06 18:34 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8axm6ae.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=chao.qin@intel.com \
--cc=joe@perches.com \
--cc=lili.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=paul.mei@intel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).