From: Felipe Balbi <balbi@kernel.org>
To: Sandeep Maheswaram <sanm@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>,
Sandeep Maheswaram <sanm@codeaurora.org>
Subject: Re: [PATCH v7 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend
Date: Wed, 28 Apr 2021 13:02:04 +0300 [thread overview]
Message-ID: <87o8dyk9r7.fsf@kernel.org> (raw)
In-Reply-To: <1619586716-8687-5-git-send-email-sanm@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
Hi,
Sandeep Maheswaram <sanm@codeaurora.org> writes:
> Configure interrupts based on hs_phy_mode to avoid triggering of
> interrupts during system suspend and suspend the device successfully.
>
> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 66183c6..82125bc 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -316,22 +316,36 @@ static void dwc3_qcom_disable_wakeup_irq(int irq)
>
> static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom)
> {
> - dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq);
> + struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
and who's using this?
> static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom)
> {
> - dwc3_qcom_enable_wakeup_irq(qcom->hs_phy_irq);
> + struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
or this?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2021-04-28 10:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 5:11 [PATCH v7 0/5] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2021-04-28 5:11 ` [PATCH v7 1/5] usb: dwc3: host: Set PHY mode during suspend Sandeep Maheswaram
2021-04-28 9:55 ` Felipe Balbi
[not found] ` <fd927828-a414-cd42-1e4a-b9e9b0744a3a@codeaurora.org>
2021-05-03 11:16 ` Felipe Balbi
2021-05-12 19:12 ` Matthias Kaehlcke
2021-05-13 13:46 ` Felipe Balbi
2021-05-13 14:37 ` Matthias Kaehlcke
2021-04-28 5:11 ` [PATCH v7 2/5] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2021-04-28 9:59 ` Felipe Balbi
2021-05-03 4:33 ` Sandeep Maheswaram
2021-05-03 11:20 ` Felipe Balbi
2021-05-12 21:47 ` Matthias Kaehlcke
2021-05-26 4:29 ` Sandeep Maheswaram
2021-04-28 5:11 ` [PATCH v7 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2021-04-28 5:11 ` [PATCH v7 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Sandeep Maheswaram
2021-04-28 10:02 ` Felipe Balbi [this message]
2021-04-28 5:11 ` [PATCH v7 5/5] usb: dwc3: qcom: Keep power domain on to support wakeup Sandeep Maheswaram
2021-04-28 10:04 ` Felipe Balbi
2021-05-13 0:23 ` Matthias Kaehlcke
2021-05-13 13:49 ` Felipe Balbi
2021-05-13 14:34 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8dyk9r7.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).