From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF3DC433DF for ; Tue, 16 Jun 2020 23:21:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C496F207E8 for ; Tue, 16 Jun 2020 23:21:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="TjLBhP6F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726534AbgFPXVR (ORCPT ); Tue, 16 Jun 2020 19:21:17 -0400 Received: from ozlabs.org ([203.11.71.1]:42775 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgFPXVR (ORCPT ); Tue, 16 Jun 2020 19:21:17 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49mkj62czzz9sRR; Wed, 17 Jun 2020 09:21:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1592349675; bh=YglC3d1qIVwIT/vjXu+XckyVGaLr6tr684jtKcQd7wA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TjLBhP6F5nvAq3REnn28vPAfAN4v2wNRC3IswZSOd3M1v2oMLUr3ZaarOk/kGkbNe l2bXoy7UF17GYKU2mlwqnp3A3sJGbG69OHzkz9w4kk9DKZrGXU3iRShzRVFHnw36Kc mlXGwtKpTsiUvUPcXeTZ/OH288mn4G1fwqul/FaDegm2WRnMaxF58Hs4pWGuM53BCx kbDgoRiGGj0QirPmEdKWaFCoYE+6QuWoHcp++BilPwisIW/Ss3Hqh9cmqu1R88H2Ne UHpEVFkkOZbaao2+YIa/+rvxgw7yOfB+lMNLRib3Za/8phJL6Y13Y8EbdWImFgTtit c//M/lvPC+WIQ== From: Michael Ellerman To: Andrew Morton , Mike Rapoport Cc: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH] powerpc/8xx: use pmd_off() to access a PMD entry in pte_update() In-Reply-To: <20200616124304.bbe36933fcd48c5f467f4be9@linux-foundation.org> References: <20200615092229.23142-1-rppt@kernel.org> <20200616124304.bbe36933fcd48c5f467f4be9@linux-foundation.org> Date: Wed, 17 Jun 2020 09:21:42 +1000 Message-ID: <87o8piegvt.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > On Mon, 15 Jun 2020 12:22:29 +0300 Mike Rapoport wrote: > >> From: Mike Rapoport >> >> The pte_update() implementation for PPC_8xx unfolds page table from the PGD >> level to access a PMD entry. Since 8xx has only 2-level page table this can >> be simplified with pmd_off() shortcut. >> >> Replace explicit unfolding with pmd_off() and drop defines of pgd_index() >> and pgd_offset() that are no longer needed. >> >> Signed-off-by: Mike Rapoport >> --- >> >> I think it's powerpc material, but I won't mind if Andrew picks it up :) > > Via the powerpc tree would be better, please. I'll take it into next for v5.9, unless there's a reason it needs to go into v5.8. cheers