From: Jani Nikula <jani.nikula@linux.intel.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] component: Silence bind error on -EPROBE_DEFER
Date: Wed, 15 Apr 2020 10:37:44 +0300 [thread overview]
Message-ID: <87o8rt5hdj.fsf@intel.com> (raw)
In-Reply-To: <CADvTj4oyK1f5fLM63GZybqdFReEa7sqQqqPyhtRWtLeyWzoDFw@mail.gmail.com>
On Tue, 14 Apr 2020, James Hilliard <james.hilliard1@gmail.com> wrote:
> On Tue, Apr 14, 2020 at 5:07 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>
>> On Fri, 10 Apr 2020, James Hilliard <james.hilliard1@gmail.com> wrote:
>> > If a component fails to bind due to -EPROBE_DEFER we should not log an
>> > error as this is not a real failure.
>> >
>> > Fixes:
>> > vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517
>> > vc4-drm soc:gpu: master bind failed: -517
>>
>> I'd think the probe defer is useful information anyway. Maybe just tone
>> down the severity and/or the message?
> That's probably not needed as there's dev_dbg logging for -EPROBE_DEFER
> elsewhere from what it looks like.
If you say so; I don't have the time to go through all the code paths.
BR,
Jani.
>
> For example:
> https://github.com/torvalds/linux/blob/v5.6/drivers/base/dd.c#L621
>>
>> BR,
>> Jani.
>>
>> >
>> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>> > ---
>> > drivers/base/component.c | 9 ++++++---
>> > 1 file changed, 6 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/base/component.c b/drivers/base/component.c
>> > index e97704104784..157c6c790578 100644
>> > --- a/drivers/base/component.c
>> > +++ b/drivers/base/component.c
>> > @@ -256,7 +256,8 @@ static int try_to_bring_up_master(struct master *master,
>> > ret = master->ops->bind(master->dev);
>> > if (ret < 0) {
>> > devres_release_group(master->dev, NULL);
>> > - dev_info(master->dev, "master bind failed: %d\n", ret);
>> > + if (ret != -EPROBE_DEFER)
>> > + dev_info(master->dev, "master bind failed: %d\n", ret);
>> > return ret;
>> > }
>> >
>> > @@ -611,8 +612,10 @@ static int component_bind(struct component *component, struct master *master,
>> > devres_release_group(component->dev, NULL);
>> > devres_release_group(master->dev, NULL);
>> >
>> > - dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
>> > - dev_name(component->dev), component->ops, ret);
>> > + if (ret != -EPROBE_DEFER) {
>> > + dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
>> > + dev_name(component->dev), component->ops, ret);
>> > + }
>> > }
>> >
>> > return ret;
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2020-04-15 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 5:41 [PATCH] component: Silence bind error on -EPROBE_DEFER James Hilliard
2020-04-14 11:07 ` Jani Nikula
2020-04-14 23:56 ` James Hilliard
2020-04-15 7:37 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8rt5hdj.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).