From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbeDHMQX (ORCPT ); Sun, 8 Apr 2018 08:16:23 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:56688 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbeDHMQW (ORCPT ); Sun, 8 Apr 2018 08:16:22 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 08 Apr 2018 14:16:20 +0200 X-ME-IP: 86.201.130.131 From: Robert Jarzmik To: Arnd Bergmann , Liam Girdwood , Mark Brown Cc: Daniel Mack , Haojian Zhuang , Vinod Koul , Jaroslav Kysela , Takashi Iwai , Linux ARM , Linux Kernel Mailing List , alsa-devel@alsa-project.org Subject: Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation References: <20180402142656.26815-1-robert.jarzmik@free.fr> <20180402142656.26815-15-robert.jarzmik@free.fr> <87lge4485x.fsf@belgarion.home> <87zi2i2ljy.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 08 Apr 2018 14:16:17 +0200 In-Reply-To: (Arnd Bergmann's message of "Thu, 5 Apr 2018 09:29:30 +0200") Message-ID: <87o9it3nce.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > I don't know exactly how the probing works, but I'd assume that we have > the correct device pointers in pxa2xx_ac97_dev_probe() and > asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and > pxa_ssp_startup(). Yes, let's try this way, in the former patch "ASoC: pxa: remove the dmaengine compat need" : +++ b/sound/arm/pxa2xx-pcm-lib.c @@ -126,7 +127,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream) return ret; return snd_dmaengine_pcm_open( - substream, dma_request_slave_channel(rtd->platform->dev, + substream, dma_request_slave_channel(rtd->cpu_dai->dev, dma_params->chan_name)); } The cpu_dai device should be either pxa27x_ac97 or pxa-ssp-dai., and amend the dma slave map accordingly. Cheers. -- Robert