From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933193AbeCNCOo (ORCPT ); Tue, 13 Mar 2018 22:14:44 -0400 Received: from ozlabs.org ([103.22.144.67]:48797 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932809AbeCNCOm (ORCPT ); Tue, 13 Mar 2018 22:14:42 -0400 Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Thiago Jung Bauermann , Dave Young Cc: AKASHI Takahiro , vgoyal@redhat.com, bhe@redhat.com, prudo@linux.vnet.ibm.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v2 2/7] kexec_file, x86, powerpc: factor out kexec_file_ops functions In-Reply-To: <87zi3b8o94.fsf@morokweng.localdomain> References: <20180306102303.9063-1-takahiro.akashi@linaro.org> <20180306102303.9063-3-takahiro.akashi@linaro.org> <20180308011303.GB2600@dhcp-128-65.nay.redhat.com> <87zi3b8o94.fsf@morokweng.localdomain> Date: Wed, 14 Mar 2018 13:14:40 +1100 Message-ID: <87o9jrflnz.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thiago Jung Bauermann writes: > Dave Young writes: > >> On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: >>> As arch_kexec_kernel_image_{probe,load}(), >>> arch_kimage_file_post_load_cleanup() and arch_kexec_kernel_verify_sig() >>> are almost duplicated among architectures, they can be commonalized with >>> an architecture-defined kexec_file_ops array. So let's factor them out. >>> >>> Signed-off-by: AKASHI Takahiro >>> Cc: Dave Young >>> Cc: Vivek Goyal >>> Cc: Baoquan He >>> Cc: Michael Ellerman >>> Cc: Thiago Jung Bauermann >>> --- >>> arch/powerpc/include/asm/kexec.h | 2 +- >>> arch/powerpc/kernel/kexec_elf_64.c | 2 +- >>> arch/powerpc/kernel/machine_kexec_file_64.c | 39 ++----------------- >>> arch/x86/include/asm/kexec-bzimage64.h | 2 +- >>> arch/x86/kernel/kexec-bzimage64.c | 2 +- >>> arch/x86/kernel/machine_kexec_64.c | 45 +--------------------- >>> include/linux/kexec.h | 13 +++---- >>> kernel/kexec_file.c | 60 +++++++++++++++++++++++++++-- >>> 8 files changed, 71 insertions(+), 94 deletions(-) >>> >> >> For this patch it also needs some review from powerpc people. > > FWIW: > > Reviewed-by: Thiago Jung Bauermann > > Also, tested on a ppc64le KVM guest: > > Tested-by: Thiago Jung Bauermann Thanks for testing. It looks OK to me. Acked-by: Michael Ellerman (powerpc) cheers