From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933819AbdCJLhD (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Mar 2017 06:37:03 -0500
Received: from mga02.intel.com ([134.134.136.20]:5760 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932907AbdCJLg7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Mar 2017 06:36:59 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,140,1486454400"; 
   d="asc'?scan'208";a="73898962"
From: Felipe Balbi <balbi@kernel.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Michal Nazarewicz <mina86@mina86.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
        mail@iagoabal.eu, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Peter Senna Tschudin <peter.senna@gmail.com>
Subject: Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free
In-Reply-To: <20170213225317.Horde.AFw31ZzUy8_Xlb1EKAA_9Ci@gator4166.hostgator.com>
References: <20170208191549.GA3998@embeddedgus> <1486582639.2133.412.camel@linux.intel.com> <20170208153322.Horde.mdD6qAMhN7aTL6u10JtoBcQ@gator4166.hostgator.com> <20170211110731.Horde.BPRpngvnMPXYcqid3jyhoJ-@gator4166.hostgator.com> <xa1tfujidqou.fsf@mina86.com> <20170213225051.Horde.FuA7hX2Mg68zi7e218F_3so@gator4166.hostgator.com> <20170213225317.Horde.AFw31ZzUy8_Xlb1EKAA_9Ci@gator4166.hostgator.com>
Date: Fri, 10 Mar 2017 13:35:58 +0200
Message-ID: <87o9x9xt29.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes:

> Remove pointer dereference after free.
>
> Addresses-Coverity-ID: 1091173
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
>   Move pointer dereference before pci_pool_free()
>   Set pointer to NULL after free
>
> Changes in v3:
>   Remove 'td->next =3D 0x00' inside for loop.
>   Remove unnecessary pointer nullification after free.
>
>   drivers/usb/gadget/udc/pch_udc.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/pch_udc.c=20=20
> b/drivers/usb/gadget/udc/pch_udc.c
> index a97da64..8a365aa 100644
> --- a/drivers/usb/gadget/udc/pch_udc.c
> +++ b/drivers/usb/gadget/udc/pch_udc.c
> @@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct=20=20
> pch_udc_dev *dev,

line wrapped. Can't apply.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljCj54ACgkQzL64meEa
mQZxCQ/+POcIgcWOZD7Qd6PKR63kjdMMDzoaXVUSA5TRIcF6Epc0NRd01HhH+xp0
p50IuWrtADQ9c7NSraaAGlD3C61ZjQWhLA15Jv7UdrgD8Q0zaduXEVtbLH8zn0aI
kaKuzFaN3Y22kS5bk8veKGiGQCo+4CRY3JlO7RowBzuIF0jUfIHXyGcubSOdxlBB
m83RTzEb2/GsF5/RAHhFdKH4hV40mQDtoEMVsGTGO8ESwI/BpnDIf6ouoRM0j2KX
9366Llmgo9BciSVxbJyxh1QMfHJ6Dp0BPuHd0Gh85qJ/rgjpC1rMmmPLPczaMTCh
zjN9Qld7IngB/AWlqqs6fgj6lnl79MjWCKxJbyMApbSL8zDLjCX/OwHiuushnOZu
hLArwfEn7Ms47HnxjUJ9YdN4wl5tQMY7mmjLoW/9Y1uPjKS5vLMusw8HW8hwghXE
1KW4a0cpVMSXdAU1iQRtF1MsQqpi6WA4hc2Rmlkf784ubf3YjAFqfFEiM6WTIg9Z
a7qZ0QGvKu4J8nOpXQ611vWKxGcuzrROwW71ecR0vLALG25q8ZZORoN3C1zRBPE9
F6DgZeahxIn6cft0+NG8RneWojTTM1jfxF7N9YyN5LQbZoVJHjQSdljWwgljzob1
ICVWxb3DHPgNN1v9CZD/IpZU5+uQuyaznQl3p9LUQ8/H+//iGW4=
=LxYD
-----END PGP SIGNATURE-----
--=-=-=--