From: Michael Ellerman <mpe@ellerman.id.au>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jeyu@redhat.com
Cc: will.deacon@arm.com, rusty@rustcorp.com.au,
akpm@linux-foundation.org, benh@kernel.crashing.org,
paulus@samba.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v3 2/3] powerpc/reloc64: add support for 32-bit CRC pseudo-symbols
Date: Fri, 25 Nov 2016 22:29:01 +1100 [thread overview]
Message-ID: <87oa13ssqq.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1477585631-18574-3-git-send-email-ard.biesheuvel@linaro.org>
Ard Biesheuvel <ard.biesheuvel@linaro.org> writes:
> diff --git a/arch/powerpc/relocs_check.sh b/arch/powerpc/relocs_check.sh
> index ec2d5c835170..2f510fbc87da 100755
> --- a/arch/powerpc/relocs_check.sh
> +++ b/arch/powerpc/relocs_check.sh
> @@ -43,7 +43,8 @@ R_PPC_ADDR16_HA
> R_PPC_RELATIVE
> R_PPC_NONE' |
> grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_' |
> - grep -E -v '\<R_PPC64_ADDR64[[:space:]]+__crc_'
> + grep -E -v '\<R_PPC64_ADDR64[[:space:]]+__crc_' |
> + grep -E -v '\<R_PPC64_ADDR32[[:space:]]+\*ABS\*'
I'm still getting:
WARNING: 24 bad relocations
c000000000d307c4 R_PPC64_ADDR32 __crc___arch_hweight16
c000000000d307c8 R_PPC64_ADDR32 __crc___arch_hweight32
c000000000d307cc R_PPC64_ADDR32 __crc___arch_hweight64
c000000000d307d0 R_PPC64_ADDR32 __crc___arch_hweight8
c000000000d30848 R_PPC64_ADDR32 __crc___bswapdi2
c000000000d30854 R_PPC64_ADDR32 __crc___clear_user
c000000000d30868 R_PPC64_ADDR32 __crc___copy_tofrom_user
c000000000d30d4c R_PPC64_ADDR32 __crc__mcount
c000000000d31344 R_PPC64_ADDR32 __crc_copy_page
c000000000d3141c R_PPC64_ADDR32 __crc_current_stack_pointer
c000000000d31840 R_PPC64_ADDR32 __crc_empty_zero_page
c000000000d31a7c R_PPC64_ADDR32 __crc_flush_dcache_range
c000000000d31a84 R_PPC64_ADDR32 __crc_flush_icache_range
c000000000d32608 R_PPC64_ADDR32 __crc_load_fp_state
c000000000d32614 R_PPC64_ADDR32 __crc_load_vr_state
c000000000d32828 R_PPC64_ADDR32 __crc_memchr
c000000000d32830 R_PPC64_ADDR32 __crc_memcmp
c000000000d32834 R_PPC64_ADDR32 __crc_memcpy
c000000000d32840 R_PPC64_ADDR32 __crc_memmove
c000000000d32888 R_PPC64_ADDR32 __crc_memset
c000000000d33c9c R_PPC64_ADDR32 __crc_store_fp_state
c000000000d33ca0 R_PPC64_ADDR32 __crc_store_vr_state
c000000000d33cf0 R_PPC64_ADDR32 __crc_strncmp
c000000000d33cf4 R_PPC64_ADDR32 __crc_strncpy
If I just add those to the whitelist it builds, but then things aren't
happy at boot:
[ 7.607687] kvm: disagrees about version of symbol module_layout
[ 7.846799] virtio: disagrees about version of symbol module_layout
[ 22.012615] crc32c_vpmsum: disagrees about version of symbol module_layout
[ 22.012959] libcrc32c: disagrees about version of symbol module_layout
cheers
next prev parent reply other threads:[~2016-11-25 11:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 16:27 [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Ard Biesheuvel
2016-10-27 16:27 ` [PATCH v3 1/3] powerpc/reloc32: fix corrupted modversion CRCs Ard Biesheuvel
2016-10-28 10:27 ` Suzuki K Poulose
2016-10-27 16:27 ` [PATCH v3 2/3] powerpc/reloc64: add support for 32-bit CRC pseudo-symbols Ard Biesheuvel
2016-11-25 11:29 ` Michael Ellerman [this message]
2016-11-25 12:48 ` Ard Biesheuvel
2016-12-01 9:39 ` Michael Ellerman
2016-12-01 9:45 ` Ard Biesheuvel
2016-12-01 16:28 ` Ard Biesheuvel
2016-10-27 16:27 ` [PATCH v3 3/3] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs Ard Biesheuvel
2016-11-04 9:55 ` [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y Ard Biesheuvel
2016-11-10 4:22 ` Michael Ellerman
2016-11-15 9:13 ` Ard Biesheuvel
2016-11-25 8:44 ` Ard Biesheuvel
2016-11-25 11:12 ` Michael Ellerman
2016-11-16 19:23 ` Uwe Kleine-König
2016-11-16 20:29 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa13ssqq.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=jeyu@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).