From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
<linux-kernel@vger.kernel.org>,
Julien Grall <julien.grall@arm.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t
Date: Fri, 29 Jul 2016 10:50:58 +0200 [thread overview]
Message-ID: <87oa5gsu8d.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <579A3E4F.2050105@citrix.com> (David Vrabel's message of "Thu, 28 Jul 2016 18:18:07 +0100")
David Vrabel <david.vrabel@citrix.com> writes:
> On 28/07/16 17:24, Vitaly Kuznetsov wrote:
>> We pass xen_vcpu_id mapping information to hypercalls which require
>> uint32_t type so it would be cleaner to have it as uint32_t. The
>> initializer to -1 can be dropped as we always do the mapping before using
>> it and we never check the 'not set' value anyway.
> [...]
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -9,7 +9,7 @@
>>
>> DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>>
>> -DECLARE_PER_CPU(int, xen_vcpu_id);
>> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
>> static inline int xen_vcpu_nr(int cpu)
>
> Should the return type of this change to uint32_t as well?
>
Yes, missed that, will do v2. Sorry!
>> {
>> return per_cpu(xen_vcpu_id, cpu);
>>
--
Vitaly
prev parent reply other threads:[~2016-07-29 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 16:24 [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t Vitaly Kuznetsov
2016-07-28 17:18 ` [Xen-devel] " David Vrabel
2016-07-29 8:50 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa5gsu8d.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).