Re: [PATCH 6/7] of_graph: add of_graph_get_top_port()

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Laurent <laurent.pinchart@ideasonboard.com>,
	Guennadi <g.liakhovetski@gmx.de>,
	Grant Likely <grant.likely@linaro.org>,
	Frank Rowand <frowand.list@gmail.com>
Cc: <kbuild-all@01.org>, Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-DT <devicetree@vger.kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 6/7] of_graph: add of_graph_get_top_port()
Date: Fri, 24 Jun 2016 09:22:13 +0000	[thread overview]
Message-ID: <87oa6rvtg6.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <201606241243.MalfOuW6%fengguang.wu@intel.com>

Hi

OK, I will post v2 patch to solve this issue.
But it will be after patch-review.

> [auto build test WARNING on robh/for-next]
> [also build test WARNING on v4.7-rc4 next-20160623]
> [cannot apply to glikely/devicetree/next]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/of_graph-prepare-for-ALSA-graph-support/20160624-105421
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux for-next
> config: arm-at91_dt_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c:22:0:
> >> include/linux/of_graph.h:54:50: warning: 'struct device' declared inside parameter list
>     struct device_node *of_graph_get_top_port(struct device *dev);
>                                                      ^
> >> include/linux/of_graph.h:54:50: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> vim +54 include/linux/of_graph.h
> 
>     38	 */
>     39	#define for_each_endpoint_of_node(parent, child) \
>     40		for (child = of_graph_get_next_endpoint(parent, NULL); child != NULL; \
>     41		     child = of_graph_get_next_endpoint(parent, child))
>     42	
>     43	#define of_graph_port_type_is_sound(n)		of_graph_port_type_is(n, "sound")
>     44	#define of_graph_endpoint_type_is_sound(n)	of_graph_endpoint_type_is(n, "sound")
>     45	#define of_graph_get_sound_endpoint_count(n)	of_graph_get_endpoint_count(n, "sound")
>     46	
>     47	#ifdef CONFIG_OF
>     48	int of_graph_parse_endpoint(const struct device_node *node,
>     49					struct of_endpoint *endpoint);
>     50	bool of_graph_port_type_is(struct device_node *port, char *type);
>     51	bool of_graph_endpoint_type_is(struct device_node *ep, char *type);
>     52	int of_graph_get_endpoint_count(const struct device_node *np, char *type);
>     53	struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 id);
>   > 54	struct device_node *of_graph_get_top_port(struct device *dev);
>     55	struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
>     56						struct device_node *previous);
>     57	struct device_node *of_graph_get_endpoint_by_regs(
>     58			const struct device_node *parent, int port_reg, int reg);
>     59	struct device_node *of_graph_get_remote_endpoint(
>     60						const struct device_node *node);
>     61	struct device_node *of_graph_get_port_parent(struct device_node *node);
>     62	struct device_node *of_graph_get_remote_port_parent(
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> [2 .config.gz <application/octet-stream (base64)>]
> 