From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933172AbcFBSS7 (ORCPT ); Thu, 2 Jun 2016 14:18:59 -0400 Received: from anholt.net ([50.246.234.109]:37570 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbcFBSS6 (ORCPT ); Thu, 2 Jun 2016 14:18:58 -0400 From: Eric Anholt To: Stefan Wahren , Gerd Hoffmann Cc: linux-rpi-kernel@lists.infradead.org, Mark Rutland , "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Lee Jones , Pawel Moll , Ian Campbell , Stephen Warren , "open list\:MULTIMEDIA CARD MMC\, SECURE DIGITAL SD AND..." , Russell King , open list , Rob Herring , Kumar Gala , "moderated list\:ARM PORT" Subject: Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it In-Reply-To: References: <1464817421-8519-1-git-send-email-kraxel@redhat.com> <1464817421-8519-33-git-send-email-kraxel@redhat.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 02 Jun 2016 11:18:52 -0700 Message-ID: <87oa7j314j.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Stefan Wahren writes: > Hi Gerd, > > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann: >> From: Eric Anholt >> >> With this we can get wifi (brcmfmac) to probe. Without it we're stuck >> with timeouts from sdio.c when it tries to set the bus width to 4. > > adding a new MMC driver to fix a wifi issue is really weird. > > Beside that there are already two MMC drivers (sdhci-bcm2835.c and > sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should > we add two new ones? Despite the fact that this is my commit, I don't think it should be merged. We should figure out why sdhci-iproc.c isn't working, instead. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXUHiMAAoJELXWKTbR/J7oczcQALF1iMnuNsooDo+vFxr/NzFS uEcTV7Dxhs6fN14seO2TWzlfz7dE+o+n5727VAQ2xfX7gxM2JTf5xKvkk6d0tf9E 16wGW23DfElDwX7GXZ4kthLTNCl2xtXyiadXTDrje3qXFmG4KU7Ikvg7/FCrrL7P eeaIju3SxCu+LlDVrZViD/gtk7DfpWnft8XSRxTiYguisHqC5e+pneQKvp6jS8aP QEw1gJA8ii3zFvftPA1tPnxNgTsqkG84prMJrhzaroHDHe33lmpCdNBny5KSTxV6 c+oFC1r0Er5AvPody9Rte7d+00o7vf224Vo7QrvUFlSusjdmiKJr9aYrAjcwxAXI 7fa9cU8A9piP9PdGEPh4lek4QHzYwh0bLH2pKKCN3ZqsVlZfeq2V21MDW/A74/Pw eWkhWc2f7vBExVbuaep2uw25B24BJpV3zZno6XgYlo9Vk0jaNGbnWPyoDSZnmICb W8VB11OwydDgNBPo31zJLXjM06fWqCIkzmZrgS4rmzjRTGRpiA15iRVSOKatk5w7 9pyrUZWjMJ/TZPh4kZ4rcQimMOHkCU0jLdopXW+M0SEA9zmu7Pd2IBj75MVDqwsy 5NOhR3XP02X4cKnwEY8ePDkYHB0atpUgi6x70GvP6q4jMNepCtb/JcdP77TRZ0Kw rQBCM7c2W6q+0niukefG =1XZI -----END PGP SIGNATURE----- --=-=-=--