linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [TRIVIAL, RESEND][ACPI, PCI] boot messages need line feeds
@ 2003-02-07 16:44 Jochen Hein
  0 siblings, 0 replies; 2+ messages in thread
From: Jochen Hein @ 2003-02-07 16:44 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: andrew.grover, trivial, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2343 bytes --]


[This time sent to Linus, CC to Andrew Grover and the Trivial Patch
Monkey]


The messages are:

pci_link-0331 [15] acpi_pci_link_set     : Link disabled
ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 0
pci_link-0331 [15] acpi_pci_link_set     : Link disabled
ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 0
pci_link-0331 [15] acpi_pci_link_set     : Link disabled
ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 0
pci_link-0331 [15] acpi_pci_link_set     : Link disabled
ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 0
pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
 pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link routing entry
 pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive IRQ for device 00:02.0
ACPI: No IRQ known for interrupt pin A of device 00:02.0 - using IRQ 255
pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
 pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link routing entry
 pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive IRQ for device 00:02.1
ACPI: No IRQ known for interrupt pin B of device 00:02.1 - using IRQ 255
pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
 pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link routing entry
 pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive IRQ for device 00:03.0
ACPI: No IRQ known for interrupt pin A of device 00:03.0pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled

                                                        ^I think, here
should be a line feed.  Next messages:

 pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link routing entry
 pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive IRQ for device 00:07.2
ACPI: No IRQ known for interrupt pin D of device 00:07.2<6>PCI: Using ACPI for IRQ routing
                                                        ^and again.

The following patch fixes it.

--- linux-2.5.59/drivers/acpi/pci_irq.c.jh	2003-01-25 10:09:10.000000000 +0100
+++ linux-2.5.59/drivers/acpi/pci_irq.c	2003-01-25 10:10:54.000000000 +0100
@@ -351,8 +351,10 @@
 			printk(" - using IRQ %d\n", dev->irq);
 			return_VALUE(dev->irq);
 		}
-		else
+		else {
+			printk("\n");
 			return_VALUE(0);
+		}
  	}
 
 	dev->irq = irq;

Jochen

-- 
Wenn Du nicht weißt was Du tust, tu's mit Eleganz.

[-- Attachment #2: Type: text/plain, Size: 59 bytes --]


-- 
Wenn Du nicht weißt was Du tust, tu's mit Eleganz.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [TRIVIAL, RESEND][ACPI, PCI] boot messages need line feeds
@ 2003-02-07 18:04 Grover, Andrew
  0 siblings, 0 replies; 2+ messages in thread
From: Grover, Andrew @ 2003-02-07 18:04 UTC (permalink / raw)
  To: Jochen Hein, Linus Torvalds; +Cc: trivial, linux-kernel

Sorry, should have acked this patch, but yes I saw it and will be including
it in the next ACPI update, unless an upstream maintainer applies it first.

Thanks -- Regards -- Andy

> -----Original Message-----
> From: Jochen Hein [mailto:jochen@jochen.org] 
> Sent: Friday, February 07, 2003 8:45 AM
> To: Linus Torvalds
> Cc: Grover, Andrew; trivial@rustcorp.com.au; linux-kernel
> Subject: [TRIVIAL, RESEND][ACPI, PCI] boot messages need line feeds
> Importance: High
> 
> 
> 
> [This time sent to Linus, CC to Andrew Grover and the Trivial Patch
> Monkey]
> 
> 
> The messages are:
> 
> pci_link-0331 [15] acpi_pci_link_set     : Link disabled
> ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 0
> pci_link-0331 [15] acpi_pci_link_set     : Link disabled
> ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 0
> pci_link-0331 [15] acpi_pci_link_set     : Link disabled
> ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 0
> pci_link-0331 [15] acpi_pci_link_set     : Link disabled
> ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 0
> pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
>  pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link 
> routing entry
>  pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive 
> IRQ for device 00:02.0
> ACPI: No IRQ known for interrupt pin A of device 00:02.0 - 
> using IRQ 255
> pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
>  pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link 
> routing entry
>  pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive 
> IRQ for device 00:02.1
> ACPI: No IRQ known for interrupt pin B of device 00:02.1 - 
> using IRQ 255
> pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
>  pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link 
> routing entry
>  pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive 
> IRQ for device 00:03.0
> ACPI: No IRQ known for interrupt pin A of device 
> 00:03.0pci_link-0484 [16] acpi_pci_link_get_irq : Link disabled
> 
>                                                         ^I think, here
> should be a line feed.  Next messages:
> 
>  pci_irq-0256 [15] acpi_pci_irq_lookup   : Invalid IRQ link 
> routing entry
>  pci_irq-0295 [15] acpi_pci_irq_derive   : Unable to derive 
> IRQ for device 00:07.2
> ACPI: No IRQ known for interrupt pin D of device 
> 00:07.2<6>PCI: Using ACPI for IRQ routing
>                                                         ^and again.
> 
> The following patch fixes it.
> 
> --- linux-2.5.59/drivers/acpi/pci_irq.c.jh	2003-01-25 
> 10:09:10.000000000 +0100
> +++ linux-2.5.59/drivers/acpi/pci_irq.c	2003-01-25 
> 10:10:54.000000000 +0100
> @@ -351,8 +351,10 @@
>  			printk(" - using IRQ %d\n", dev->irq);
>  			return_VALUE(dev->irq);
>  		}
> -		else
> +		else {
> +			printk("\n");
>  			return_VALUE(0);
> +		}
>   	}
>  
>  	dev->irq = irq;
> 
> Jochen
> 
> -- 
> Wenn Du nicht weißt was Du tust, tu's mit Eleganz.
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-02-07 17:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-07 16:44 [TRIVIAL, RESEND][ACPI, PCI] boot messages need line feeds Jochen Hein
2003-02-07 18:04 Grover, Andrew

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).