From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Jiada Wang <jiwang_wang@mentor.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <jiada_wang@mentor.com>,
<Dean_Jenkins@mentor.com>, <erosca@de.adit-jv.com>
Subject: Re: [PATCH v1 1/1] rsnd: ssiu: add missing .quit callback for gen2
Date: Mon, 18 Jul 2022 23:17:46 +0000 [thread overview]
Message-ID: <87pmi2ko2z.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20220718110404.1529085-1-jiwang_wang@mentor.com>
Hi
> From: Wang Jiada <jiada_wang@mentor.com>
>
> commit 83b220cf8eb2a ("ASoC: rsnd: implement BUSIF related
> code in ssiu.c") moved BUSIF related code in ssiu.c
> which added .quit callback in ssiu.c to disable error irq
> when ssiu quits.
>
> But .quit callback was added only for gen1 and is missing
> for gen2, this causes error irq is left enabled after ssiu
> quits on gen2.
>
> This commit adds missing .quit callback for gen2
>
> Signed-off-by: Wang Jiada <jiada_wang@mentor.com>
> Cc: Dean Jenkins <Dean_Jenkins@mentor.com>
> Cc: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2022-07-18 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 11:04 [PATCH v1 1/1] rsnd: ssiu: add missing .quit callback for gen2 Jiada Wang
2022-07-18 23:17 ` Kuninori Morimoto [this message]
2022-07-19 17:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmi2ko2z.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=Dean_Jenkins@mentor.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=erosca@de.adit-jv.com \
--cc=jiada_wang@mentor.com \
--cc=jiwang_wang@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).