From: Peter Korsgaard <peter@korsgaard.com>
To: Tanmay Shah <tanmay.shah@xilinx.com>
Cc: <bjorn.andersson@linaro.org>, <mathieu.poirier@linaro.org>,
<robh+dt@kernel.org>, <krzk+dt@kernel.org>,
<michal.simek@xilinx.com>, <ben.levinsky@xilinx.com>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<openamp-system-reference@lists.openampproject.org>
Subject: Re: [PATCH v8 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver
Date: Tue, 07 Jun 2022 15:03:29 +0200 [thread overview]
Message-ID: <87pmjkwrq6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220602203834.3675160-7-tanmay.shah@xilinx.com> (Tanmay Shah's message of "Thu, 2 Jun 2022 13:38:34 -0700")
>>>>> "Tanmay" == Tanmay Shah <tanmay.shah@xilinx.com> writes:
Hi,
> This driver enables r5f dual core Real time Processing Unit subsystem
> available on Xilinx Zynq Ultrascale MPSoC Platform. RPU subsystem
> (cluster) can be configured in different modes e.g. split mode in which
> two r5f cores work independent of each other and lock-step mode in which
> both r5f cores execute same code clock-for-clock and notify if the
> result is different.
> The Xilinx r5 Remoteproc Driver boots the RPU cores via calls to the Xilinx
> Platform Management Unit that handles the R5 configuration, memory access
> and R5 lifecycle management. The interface to this manager is done in this
> driver via zynqmp_pm_* function calls.
> Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
> Signed-off-by: Tanmay Shah <tanmay.shah@xilinx.com>
> + * zynqmp_r5_set_mode - set RPU operation mode
> + *
> + * set RPU operation mode
> + *
> + * Return: 0 for success, negative value for failure
> + */
> +static int zynqmp_r5_set_mode(struct zynqmp_r5_core *r5_core,
> + enum rpu_oper_mode fw_reg_val,
> + enum rpu_tcm_comb tcm_mode)
> +{
NIT: That is an odd name for the lockstep/split argument. Why do you
need to specify both R5F mode and TCM configuration, isn't the TCM mode
implied by the R5F mode?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2022-06-07 13:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 20:38 [PATCH v8 0/6] Add Xilinx RPU subsystem support Tanmay Shah
2022-06-02 20:38 ` [PATCH v8 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings Tanmay Shah
2022-06-03 6:33 ` Peter Korsgaard
2022-06-09 17:41 ` Rob Herring
2022-06-10 16:17 ` Tanmay Shah
2022-06-07 17:32 ` Tanmay Shah
2022-06-09 17:33 ` Rob Herring
2022-06-10 16:18 ` Tanmay Shah
2022-06-02 20:38 ` [PATCH v8 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node Tanmay Shah
2022-06-02 20:38 ` [PATCH v8 3/6] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Tanmay Shah
2022-06-02 20:38 ` [PATCH v8 4/6] firmware: xilinx: Add shutdown/wakeup APIs Tanmay Shah
2022-06-02 20:38 ` [PATCH v8 5/6] firmware: xilinx: Add RPU configuration APIs Tanmay Shah
2022-06-02 20:38 ` [PATCH v8 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Tanmay Shah
2022-06-02 21:07 ` Christophe JAILLET
2022-06-07 13:03 ` Peter Korsgaard [this message]
2022-06-07 16:52 ` Mathieu Poirier
2022-06-13 20:59 ` Tanmay Shah
[not found] ` <2d905471-34f0-60d9-90f8-17ea34683836@amd.com>
2022-06-21 19:25 ` Mathieu Poirier
2022-06-08 17:37 ` Mathieu Poirier
2022-06-13 21:36 ` Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmjkwrq6.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=ben.levinsky@xilinx.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@xilinx.com \
--cc=openamp-system-reference@lists.openampproject.org \
--cc=robh+dt@kernel.org \
--cc=tanmay.shah@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).