From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>,
kernel test robot <oliver.sang@intel.com>,
Eric Biggers <ebiggers@google.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, kernel test robot <lkp@intel.com>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [x86/uaccess] 9c5743dff4: WARNING:at_arch/x86/mm/extable.c:#ex_handler_fprestore
Date: Sun, 15 May 2022 16:54:47 +0200 [thread overview]
Message-ID: <87pmkerglk.ffs@tglx> (raw)
In-Reply-To: <8735hbryn6.ffs@tglx>
On Sun, May 15 2022 at 10:25, Thomas Gleixner wrote:
> On Fri, May 13 2022 at 09:52, Linus Torvalds wrote:
> The code which copies the ptrace supplied state has a pile of sanity
> checks to catch invalid state, but I wouldn't bet my hat on it that it's
> 100% complete. We can be more defensive here, but I would be surprised.
>
> Something like the untested below. I'll expose it to some testing to see
> what explodes.
I was not able to get something broken past the existing sanity checks
which was caught by the trial restore. I seems the FPU units are pretty
resilent against random nonsense except for the XSTATE header and the
MXCRS content. Though I ponder to just add that trial restore due to
paranoia.
Thanks,
tglx
prev parent reply other threads:[~2022-05-15 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 8:54 [x86/uaccess] 9c5743dff4: WARNING:at_arch/x86/mm/extable.c:#ex_handler_fprestore kernel test robot
2022-05-13 16:52 ` Linus Torvalds
2022-05-13 17:12 ` Borislav Petkov
2022-05-15 3:06 ` Oliver Sang
2022-05-15 8:25 ` Thomas Gleixner
2022-05-15 14:54 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmkerglk.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=oliver.sang@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).