From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65493C433FE for ; Mon, 1 Nov 2021 16:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CABA61166 for ; Mon, 1 Nov 2021 16:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232733AbhKAQY0 (ORCPT ); Mon, 1 Nov 2021 12:24:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60152 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbhKAQYU (ORCPT ); Mon, 1 Nov 2021 12:24:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D0pDbHtTcR82UVCQHWAbgqpuu1KGubZnwzSQ8mPGn+I=; b=i/02LgkUvloue5jfupZk1IncQ6Q8mOr5C6ymya0EbLkkFdRA5uH0OuJ0cxEZJhxtJQvBw2 N6qj0wLnyh0i4A6AMLnpNg+KdoMggs9DYcph0QJ7nOLfV4AusSCKYW2svQhKTSYG+Sk4fa lZlSyJr9jWamWWYuNUtaCHlmpOOeE6o= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-XSEwg3fpM-GK7yQmtqHuYA-1; Mon, 01 Nov 2021 12:21:45 -0400 X-MC-Unique: XSEwg3fpM-GK7yQmtqHuYA-1 Received: by mail-wm1-f70.google.com with SMTP id b15-20020a1c800f000000b0033214e5b021so3236402wmd.3 for ; Mon, 01 Nov 2021 09:21:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=D0pDbHtTcR82UVCQHWAbgqpuu1KGubZnwzSQ8mPGn+I=; b=gpHD5yLHluUTk9TeS8Vae6m2nWtGaY4ohney4bN4WSPnlV4zUn+KFLx8MQZUQRDJt2 7oMPh/eioaPWFjhLszkk7Ka+mPPzXp+R8BUS4vcOITyoISYe5CGPwvJj6aWKg/e90DQp nQ0uzUzZpTNMFm+Xi+Dd+45McR5kKLGDYgqvgtQCH756skSAOMQ743QXJ1jRFYx46rpe 9hlZL7ORmC2ueQaT4XrUo9ozSpSCL03NztHlbqBssQRnLw45HEua0qq80Op4fo9zUxXc XDLsz8kxRQUHSz2ZflOpmeEeV7VyLvpf0cBMOaWZtnCYs4q2J/MAo+ALGT52xkM8o2RK WN9Q== X-Gm-Message-State: AOAM531ULelBSfS0krNWyVrgk5f9KKhCpYH3iCsl80+A/bXKaPgqqrHT RytqYAtltMTssrsnBgK9P2JzYBWdPbEevnTo4KBVAjpbGBr+Axlhzl3uoYn16xwBNKkROk2NbHI Wnw+D3fKF7iKjwZ1+2H/28RGR X-Received: by 2002:a05:600c:35cb:: with SMTP id r11mr32964170wmq.76.1635783704388; Mon, 01 Nov 2021 09:21:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg54pONXTEoQJ+SUEIJ8W1KRheAbFXi6E/qkqBCPrstK3ffBjgfgu7fIfChSWRMD/80LyMAg== X-Received: by 2002:a05:600c:35cb:: with SMTP id r11mr32964133wmq.76.1635783704156; Mon, 01 Nov 2021 09:21:44 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id z8sm8283223wrh.54.2021.11.01.09.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:43 -0700 (PDT) From: Vitaly Kuznetsov To: Maxim Levitsky , kvm@vger.kernel.org Cc: Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , Borislav Petkov , Paolo Bonzini , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Joerg Roedel , "H. Peter Anvin" , Maxim Levitsky , Thomas Gleixner , Bandan Das , Wanpeng Li , Jim Mattson , Sean Christopherson , Wei Huang , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Ingo Molnar Subject: Re: [PATCH v2 1/6] KVM: x86: SVM: add module param to control LBR virtualization In-Reply-To: <20211101140324.197921-2-mlevitsk@redhat.com> References: <20211101140324.197921-1-mlevitsk@redhat.com> <20211101140324.197921-2-mlevitsk@redhat.com> Date: Mon, 01 Nov 2021 17:21:42 +0100 Message-ID: <87pmrjkfs9.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maxim Levitsky writes: > This is useful for debug and also makes it consistent with > the rest of the SVM optional features. > > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/svm/svm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 21bb81710e0f6..2b5f8e10d686d 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -186,12 +186,13 @@ module_param(vls, int, 0444); > static int vgif = true; > module_param(vgif, int, 0444); > > +static int tsc_scaling = true; > +module_param(tsc_scaling, int, 0444); > + > /* enable/disable LBR virtualization */ > static int lbrv = true; > module_param(lbrv, int, 0444); > > -static int tsc_scaling = true; > -module_param(tsc_scaling, int, 0444); Subject line says "KVM: x86: SVM: add module param to control LBR virtualization" but the patch just moves 'tsc_scaling' param a couple lines up. Was this intended or is this a rebase artifact and the patch just needs to be dropped? > > /* > * enable / disable AVIC. Because the defaults differ for APICv -- Vitaly