From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17335C4320E for ; Wed, 28 Jul 2021 14:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F18A760C3E for ; Wed, 28 Jul 2021 14:55:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237040AbhG1Oz2 (ORCPT ); Wed, 28 Jul 2021 10:55:28 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:36246 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236626AbhG1OzK (ORCPT ); Wed, 28 Jul 2021 10:55:10 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1627484108; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=Ep08OHNA6cPjguVx+7EyjN81zK8S0EpKX+rpXN2XyL4=; b=kXeerlg5yu9Acqb/CYHp7O1EKn04tR9WP7DibB+PIZVvWc4r3pEM04uVe5s5gJUKwMxybZl8 CXtDnPZFic5igbpbJtG118ZzsYdb7jGyNXQuxXnZEJE2Ha9QthZEpSjkYYxHI0UamER8IdmF HOhCrlsTvdkGIIo6UjxkO6FZ41U= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 61016fb9b653fbdadd3e24d5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 28 Jul 2021 14:54:49 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D33CAC43148; Wed, 28 Jul 2021 14:54:48 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9DD15C43144; Wed, 28 Jul 2021 14:54:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9DD15C43144 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Luis Chamberlain Cc: Christian Lamparter , Lukas Bulwahn , linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Dwaipayan Ray , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] intersil: remove obsolete prism54 wireless driver References: <20210713054025.32006-1-lukas.bulwahn@gmail.com> <20210715220644.2d2xfututdoimszm@garbanzo> <6f490ee6-4879-cac5-d351-112f21c6b23f@gmail.com> <87mtq8guh7.fsf@codeaurora.org> Date: Wed, 28 Jul 2021 17:54:40 +0300 In-Reply-To: (Luis Chamberlain's message of "Tue, 27 Jul 2021 05:42:28 -0700") Message-ID: <87pmv2fpzj.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luis Chamberlain writes: > On Tue, Jul 27, 2021 at 09:07:48AM +0300, Kalle Valo wrote: >> Christian Lamparter writes: >> >> > On 16/07/2021 00:06, Luis Chamberlain wrote: >> >> On Tue, Jul 13, 2021 at 07:40:25AM +0200, Lukas Bulwahn wrote: >> >>> Commit 1d89cae1b47d ("MAINTAINERS: mark prism54 obsolete") indicated the >> >>> prism54 driver as obsolete in July 2010. >> >>> >> >>> Now, after being exposed for ten years to refactoring, general tree-wide >> >>> changes and various janitor clean-up, it is really time to delete the >> >>> driver for good. >> >>> >> >>> This was discovered as part of a checkpatch evaluation, investigating all >> >>> reports of checkpatch's WARNING:OBSOLETE check. >> >>> >> >>> Signed-off-by: Lukas Bulwahn >> >>> --- >> > >> > noted. Farewell. >> >> How do we know that there are no users left? It's surprising how ancient >> hardware some people use. Is the driver broken or what? >> >> (Reads commit 1d89cae1b47d) >> >> Ah, p54 is supposed to replace prism54. Does that include all the >> hardware supported by prism54? > > There was a one off chipset someone told me about long ago that p54 > didn't work for. But that persond disappeared from the face of the > earth. Additionally, distributions have been blacklisting prism54 > for years now. > >> If yes, that should be clearly documented >> in the commit log and I can add that. > > Agreed. Feel free to quote the above. Thanks, will do. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches