From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB73DC43461 for ; Wed, 21 Apr 2021 09:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7F0261430 for ; Wed, 21 Apr 2021 09:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237845AbhDUJIl (ORCPT ); Wed, 21 Apr 2021 05:08:41 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:31936 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237625AbhDUJIj (ORCPT ); Wed, 21 Apr 2021 05:08:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618996086; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=OX6XiY6joBfdyzSpmKbHuqcmnZRR1EQFEvTqQUGxAWo=; b=A5RTzwZiLVVmi4sQHSkTy5ItGtVNTLwJ148b5FJ7MNaxDk+JELe/IhbU5lwh+oUuDqkdctsg 134SG4ltfdkj+vbN33+NREobVdXkeGzB+/DThfxm4L1cX7lXF11fqglpvfp2Kd56bvsPCSiD sGt/BS9lpP2XuadF42K64JQwHrc= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 607feb54f34440a9d470a5ff (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 21 Apr 2021 09:07:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 648BDC43147; Wed, 21 Apr 2021 09:07:31 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D3F43C43217; Wed, 21 Apr 2021 09:07:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D3F43C43217 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Joe Perches Cc: Colin King , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] brcmsmac: fix shift on 4 bit masked value References: <20210318164513.19600-1-colin.king@canonical.com> <20210418061021.AB25CC43217@smtp.codeaurora.org> <78ad5b527aa1da06569fd5ae422ea2a403ef40a0.camel@perches.com> Date: Wed, 21 Apr 2021 12:07:24 +0300 In-Reply-To: <78ad5b527aa1da06569fd5ae422ea2a403ef40a0.camel@perches.com> (Joe Perches's message of "Sun, 18 Apr 2021 00:58:40 -0700") Message-ID: <87pmyoj99v.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: > On Sun, 2021-04-18 at 06:10 +0000, Kalle Valo wrote: >> Colin King wrote: >> >> > From: Colin Ian King >> > >> > The calculation of offtune_val seems incorrect, the u16 value in >> > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then >> > shifted 8 places right so that always ends up as a zero result. I >> > believe the intended shift was 4 bits to the right. Fix this. >> > >> > [Note: not tested, I don't have the H/W] >> > >> > Addresses-Coverity: ("Operands don't affect result") >> > Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers") >> > Signed-off-by: Colin Ian King >> >> I think this needs review from someone familiar with the hardware. >> >> Patch set to Changes Requested. > > What "change" are you requesting here? Don't take patchwork states literally, a better name for this state would be "Needs work" or something like that. > Likely there needs to be some other setting for the patch. > > Perhaps "deferred" as you seem to be requesting a review > and there's no actual change necessary, just approval from > someone with the hardware and that someone test the patch. I already asked for help on April 7th and nobody replied, so I'm dropping this now. The patch can be resent if/when the change is confirmed to be correct. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches