From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16]
Date: Thu, 15 Apr 2021 12:20:14 +0300 [thread overview]
Message-ID: <87pmyvgb01.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <YHf6s2r28XOtP2+2@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote:
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>>
>> >> Using raw buffer APIs against uuid_t / guid_t.
>> >
>> > So you want to do that, or you do not want to do that? Totally
>> > confused,
>>
>> My understanding is that:
>> 1) generate_random_uuid() use is allegedly bad even though it's in their
>> header,
>> 2) poking directly at the byte array inside uuid_t is bad, even though,
>> again, header.
>>
>> It is, indeed, not ideal.
>>
>> If agreeable, I'll update this patch to the below and respin the whole
>> series.
>
> You are showing that Andy wrote this, when you are the one that did :(
That's intentional, it's Andy's patch. In fact, it was probably me who
insisted on the open-coded-byte-array version, in an offline
conversation some time ago. I'd like to keep his name on it if that's
ok. I've re-sent it [1] as a standalone patch.
> Anyway, I've dropped this single patch from the series and applied the
> rest. Feel free to send this patch as a stand-alone one once you have
> the authorship issues sorted out.
Thank you!
[1] https://lore.kernel.org/lkml/20210415091555.88085-1-alexander.shishkin@linux.intel.com/
Regards,
--
Alex
next prev parent reply other threads:[~2021-04-15 9:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 17:12 [PATCH 0/7] stm class/intel_th: Updates for v5.13 Alexander Shishkin
2021-04-14 17:12 ` [PATCH 1/7] stm class: Remove an unused function Alexander Shishkin
2021-04-14 17:12 ` [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16] Alexander Shishkin
2021-04-14 17:33 ` Greg Kroah-Hartman
2021-04-14 17:47 ` Andy Shevchenko
2021-04-14 18:56 ` Greg Kroah-Hartman
2021-04-14 19:12 ` Andy Shevchenko
2021-04-14 19:14 ` Alexander Shishkin
2021-04-14 19:16 ` Andy Shevchenko
2021-04-15 8:34 ` Greg Kroah-Hartman
2021-04-15 8:48 ` Andy Shevchenko
2021-04-15 9:08 ` Greg Kroah-Hartman
2021-04-15 9:20 ` Alexander Shishkin [this message]
2021-04-14 17:12 ` [PATCH 3/7] intel_th: Constify all drvdata references Alexander Shishkin
2021-04-14 17:12 ` [PATCH 4/7] intel_th: Constify attribute_group structs Alexander Shishkin
2021-04-14 17:12 ` [PATCH 5/7] intel_th: Consistency and off-by-one fix Alexander Shishkin
2021-04-14 17:12 ` [PATCH 6/7] intel_th: pci: Add Rocket Lake CPU support Alexander Shishkin
2021-04-14 17:12 ` [PATCH 7/7] intel_th: pci: Add Alder Lake-M support Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmyvgb01.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).